Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63668
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 67.200.53.250 as permitted sender)
Message-ID: <508C1D07.5070909@zerocue.com>
Date: Sat, 27 Oct 2012 12:42:31 -0500
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>
CC: PHP Developers Mailing List <internals@lists.php.net>
References: <508A695F.8080308@zerocue.com> <508AA0B8.8090308@sugarcrm.com>
In-Reply-To: <508AA0B8.8090308@sugarcrm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Property Accessors v1.2 : Extra shorthand declaration
From: cpriest@zerocue.com (Clint Priest)


On 10/26/2012 9:39 AM, Stas Malyshev wrote:
> Hi!
>
>> /* Would be equivalent to this */
>>
>> class TimePeriod {
>>       public $date {
>>           get() { return $this->date; }
>>           set(DateTime $value) { $this->date = $value;}
>>       }
>> }
> I don't think this has a use case and this encourages mixing variables
> with properties (which I'm not sure is a very good idea) and writing
> slower and more complicated code which doesn't actually do any
> additional work. I'd rather not encourage it. If you want it - fine,
> implement it, but I don't think supporting it is good.
I would agree that it should not be in here, AFAIK only Nikita was 
pushing for this... anyone else want to fight to have this functionality?
> Also, "get() { return $this->date; }" implies there is a thing called
> "$this->date" which is not the property itself. So what is it? Should
> there be additional "public $date;" declaration in your code? Is it
> implied that property definition also creates a variable inside class
> automatically - I was under expression this does not happen, and nothing
> in the RFC implies it. Should it be $this->__date maybe like in
> "automatic accessors" part of the RFC?
This is related to accessors shadowing properties, if that's the case 
then $this->date would retrieve an actual property named date (and since 
it's shadowed by the accessor it could never be accessed from outside 
the accessor.  See the shadowing thread.

-- 
-Clint