Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6364
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Fri, 12 Dec 2003 11:02:38 -0800 (PST)
To: Ilia Alshanetsky <ilia@prohost.org>
cc: Moriyoshi Koizumi <moriyoshi@at.wakwak.com>,
        PHP Internals <internals@lists.php.net>
In-Reply-To: <200312121407.48578.ilia@prohost.org>
Message-ID: <Pine.LNX.4.58.0312121100100.1008@thinkpad.lerdorf.com>
References: <25BBBBC2-2CD2-11D8-8FCC-000A95CE0C62@at.wakwak.com>
 <200312121407.48578.ilia@prohost.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [PHP-DEV] Re: Regarding the latest patch on fgetcsv() (stable
 branch)
From: rasmus@php.net (Rasmus Lerdorf)

On Fri, 12 Dec 2003, Ilia Alshanetsky wrote:
> That said, the whole space trimming behavior seems a little unusual since it 
> will corrupt content especially if said content contains binary data. IMHO 
> the data read by fgetcsv() should be fetched in such a manner so that the 
> original string can be recreated.

I agree that it would be a good idea to provide a mechanism to do that, 
but at this point I don't think we should be changing the behaviour of 
fgetcsv() in neither the stable branch nor the HEAD branch.  I'd add a new 
binary-safe version of the function instead for this.  Or an optional arg, 
but fgetcsv() already has 2 optional args.

-Rasmus