Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6363 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88241 invoked by uid 1010); 12 Dec 2003 18:56:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 88176 invoked from network); 12 Dec 2003 18:56:32 -0000 Received: from unknown (HELO asuka.nerv) (24.112.18.98) by pb1.pair.com with SMTP; 12 Dec 2003 18:56:32 -0000 Received: (qmail 3179 invoked from network); 12 Dec 2003 13:51:45 -0000 Received: from rei.nerv (HELO dummy.com) (rei@192.168.1.1) by asuka.nerv with SMTP; 12 Dec 2003 13:51:45 -0000 Reply-To: ilia@prohost.org Organization: Prohost.org To: Moriyoshi Koizumi , PHP Internals Date: Fri, 12 Dec 2003 14:07:48 -0500 User-Agent: KMail/1.5.4 References: <25BBBBC2-2CD2-11D8-8FCC-000A95CE0C62@at.wakwak.com> In-Reply-To: <25BBBBC2-2CD2-11D8-8FCC-000A95CE0C62@at.wakwak.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200312121407.48578.ilia@prohost.org> Subject: Re: Regarding the latest patch on fgetcsv() (stable branch) From: ilia@prohost.org (Ilia Alshanetsky) On December 12, 2003 01:36 pm, Moriyoshi Koizumi wrote: > What do you think of this? I'll apply a fix momentarily, it wouldn't do to break BC in stable branch. That said, the whole space trimming behavior seems a little unusual since it will corrupt content especially if said content contains binary data. IMHO the data read by fgetcsv() should be fetched in such a manner so that the original string can be recreated. Ilia