Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63386
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.217.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <9570D903A3BECE4092E924C2985CE485612B53E4@MBX202.domain.local>
References: <9570D903A3BECE4092E924C2985CE485612B53E4@MBX202.domain.local>
Date: Sat, 13 Oct 2012 10:06:29 +0200
Message-ID: <CAEPJdu=1_TWqzyf+sKep+0zBMMJnWjw4R=WM8R95fC=S4UOSXg@mail.gmail.com>
To: Clint Priest <cpriest@zerocue.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d042f94bc18858204cbec488f
Subject: Re: [PHP-DEV] [PHP-DEV [RFC] Property Accessors v1.2
From: kontakt@beberlei.de (Benjamin Eberlei)

--f46d042f94bc18858204cbec488f
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Oct 12, 2012 at 7:23 AM, Clint Priest <cpriest@zerocue.com> wrote:

> Alright, here is the updated RFC as per discussions for the last few days:
>
> https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented
>
> If you could read it over, make sure I have all of your concerns correctly
> addressed and we can leave this open for the two week waiting period while
> I make the final code changes.
>
> -Clint
>
>
Can we discuss the removal of automatic get; set; again? For me that was
the best feature of the whole RFC, essentially allowing to define a
property with getter/setter in 1 LOC. Allowing future overriding of that
getter/Setter if the application required it.

This is absolutely essential for database backed recods which will have
tons of those property accessors. Now if i apply PSR coding styles to
accessors, then i end up with 11 LOC for accessors defining a property, a
property accessor and get/set functions, compared to 10 LOC with usual
getter/setters.

As i understand it was removed because of the unclear behavior when we have
the following code:

public $Foo { get(); set($value) { $this->??? = $value; }}

I propose to reintroduce this shortcut, if you define both getter/setter as
automatic:

public $Foo { get(); set(); }

The syntax is up for grabs, but it would be very sad if this be removed.

greetings,
Benjamin

--f46d042f94bc18858204cbec488f--