Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:63382 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 28745 invoked from network); 13 Oct 2012 04:44:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Oct 2012 04:44:26 -0000 Authentication-Results: pb1.pair.com smtp.mail=cpriest@zerocue.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=cpriest@zerocue.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zerocue.com designates 74.115.204.80 as permitted sender) X-PHP-List-Original-Sender: cpriest@zerocue.com X-Host-Fingerprint: 74.115.204.80 relay-hub206.domainlocalhost.com Received: from [74.115.204.80] ([74.115.204.80:43181] helo=relay-hub206.domainlocalhost.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id AC/E5-06472-7A1F8705 for ; Sat, 13 Oct 2012 00:44:26 -0400 Received: from MBX202.domain.local ([169.254.169.44]) by HUB206.domain.local ([192.168.68.50]) with mapi id 14.02.0283.003; Sat, 13 Oct 2012 00:43:35 -0400 To: Levi Morrison CC: "internals@lists.php.net" Thread-Topic: [PHP-DEV] [PHP-DEV [RFC] Property Accessors v1.2 Thread-Index: Ac2oOZ3+vAOzWRcnRpOb6a/hOVK5+AAcAWGAABTuK0A= Date: Sat, 13 Oct 2012 04:43:34 +0000 Message-ID: <9570D903A3BECE4092E924C2985CE485612B573F@MBX202.domain.local> References: <9570D903A3BECE4092E924C2985CE485612B53E4@MBX202.domain.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.64.25] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] [PHP-DEV [RFC] Property Accessors v1.2 From: cpriest@zerocue.com (Clint Priest) I must have missed taking that part out of the RFC, they would not be neede= d any more with those keywords being removed. > -----Original Message----- > From: Levi Morrison [mailto:morrison.levi@gmail.com] > Sent: Friday, October 12, 2012 9:45 AM > To: Clint Priest > Cc: internals@lists.php.net > Subject: Re: [PHP-DEV] [PHP-DEV [RFC] Property Accessors v1.2 >=20 > On Thu, Oct 11, 2012 at 11:23 PM, Clint Priest wrot= e: > > Alright, here is the updated RFC as per discussions for the last few da= ys: > > > > https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented > > > > If you could read it over, make sure I have all of your concerns correc= tly addressed and we can leave this open for the two week > waiting period while I make the final code changes. > > > > -Clint > > >=20 > I'm not sure if that RFC is up to date; are `ZEND_ACC_READONLY` and `ZEND= _ACC_WRITEONLY` still there? Are there still 79 test cases? > I'd like to see wider coverage if you can think of more things to tests. > Ideally every conditional statement has a test. >=20 > I used to be very against this RFC but I admit the details have improved = a lot with the ability to type hint and the removal of read and > write only keywords. >=20 > Levi Morrison