Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63378
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <9570D903A3BECE4092E924C2985CE485612B53E4@MBX202.domain.local>
References: <9570D903A3BECE4092E924C2985CE485612B53E4@MBX202.domain.local>
Date: Fri, 12 Oct 2012 08:44:41 -0600
Message-ID: <CAFMT4NofUJoowv1ZCDnTUPCadWi7BY34LBMR9su4N6S3-NFjwA@mail.gmail.com>
To: Clint Priest <cpriest@zerocue.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PHP-DEV [RFC] Property Accessors v1.2
From: morrison.levi@gmail.com (Levi Morrison)

On Thu, Oct 11, 2012 at 11:23 PM, Clint Priest <cpriest@zerocue.com> wrote:
> Alright, here is the updated RFC as per discussions for the last few days:
>
> https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented
>
> If you could read it over, make sure I have all of your concerns correctly addressed and we can leave this open for the two week waiting period while I make the final code changes.
>
> -Clint
>

I'm not sure if that RFC is up to date; are `ZEND_ACC_READONLY` and
`ZEND_ACC_WRITEONLY` still there? Are there still 79 test cases? I'd
like to see wider coverage if you can think of more things to tests.
Ideally every conditional statement has a test.

I used to be very against this RFC but I admit the details have
improved a lot with the ability to type hint and the removal of read
and write only keywords.

Levi Morrison