Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63305
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c9eTXLj5+F5KY2rdFy4zC=qkETEcBcdJfr5Of_63XCgAw@mail.gmail.com>
References: <9570D903A3BECE4092E924C2985CE485612B3B48@MBX202.domain.local>
	<CAF+90c9eTXLj5+F5KY2rdFy4zC=qkETEcBcdJfr5Of_63XCgAw@mail.gmail.com>
Date: Tue, 9 Oct 2012 14:41:25 +0100
Message-ID: <CAPwsocHtBV+L=UtUuOAjEYwFtVnffy2AoWnpSk_aGKTZvaLozg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Clint Priest <cpriest@zerocue.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [RFC] Propety Accessors v1.1
From: leight@gmail.com (Leigh)

> What concerns me with the current implementation is that it leaks many
> implementation details, in particular the fact that the accessors are
> implemented as *real* __getXYZ methods and automatic implementations
> also use *real* $__XYZ properties.

Further to this, take the following example.

public $_state {
    set { ... }
}

This automatically generates a "hidden" function __set_state(), which
is a magic method already (and should be declared static, and take an
array as it's only parameter)

Another fine example of how automatically generating *real*
implementations can potentially break things.