Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63292
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.42 as permitted sender)
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
In-Reply-To: <CAOg_pRTo3_E6CJ_b6BBT4ZkKxEgaUXs67VeahbWdUStcxbneZQ@mail.gmail.com>
References: <CAOg_pRTo3_E6CJ_b6BBT4ZkKxEgaUXs67VeahbWdUStcxbneZQ@mail.gmail.com>
Date: Tue, 9 Oct 2012 12:59:59 +0800
Message-ID: <CAHMUw2HBpWP6dVau1FKDB6JRpqTASJuzZv-Y38yB6U_nXg98nA@mail.gmail.com>
To: Nicolai Scheer <scope@planetavent.de>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=047d7b2ee657ca15db04cb993517
Subject: Re: [PHP-DEV] stream_get_line behaviour Bug #63240
From: datibbaw@php.net (Tjerk Anne Meesters)

--047d7b2ee657ca15db04cb993517
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Oct 9, 2012 at 12:14 AM, Nicolai Scheer <scope@planetavent.de>wrote:

> Hi!
>
> We switched from php 5.3.10 to 5.3.17 this weekend and stumbled upon a
> behaviour of stream_get_line that is most likely a bug and breaks a
> lot of our file processing code.
>
> The issue seems to have been introduced from 5.3.10 to 5.3.11.
>
> I opened a bug report: #63240.
>

I've managed to reduce the code to this; it's very specific:

$file = __DIR__ . '/input_dummy.txt';
$delimiter = 'MM';
file_put_contents($file, str_repeat('.', 8189) . $delimiter . $delimiter);

$fh = fopen($file, "rb");

stream_get_line($fh, 8192, $delimiter);
var_dump($delimiter === stream_get_line($fh, 8192, $delimter));

fclose($fh);
unlink($file);

If the internal buffer length is 8192, after the first call to
stream_get_line() the read position (x) and physical file pointer (y)
should be positioned like so:

.......MM(x)M(y)M

The fact that (y) is in between the delimiter seems to cause an issue.


> The issue seems to be related to #44607, but that one got fixed years ago.
>
> Is anybody able to confirm this behaviour or has stumbled upon this?
>
> Furthermore the behaviour of stream_get_line on an empty file seems to
> have changed between php 5.3.10 and php 5.3.11:
>
> <?php
>
> $file = __DIR__ . 'empty.txt';
> file_put_contents( $file, '' );
> $fh = fopen( $file, 'rb' );
> $data = stream_get_line( $fh, 4096 );
> var_dump( $data );
>
> result in
>
> string(0) ""
>
> for php 5.3.10
>
> and in
>
> bool(false)
>
> for php > 5.3.10.

I don't know if this should be considered a bug, but as far as I know
> such a behaviour should not change during minor releases...
>
> Any insight is appreciated!
>
> Greetings
>
> Nico
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
--
Tjerk

--047d7b2ee657ca15db04cb993517--