Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63287
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEPJdu=pRSDRD68t3o7XVbWRo-FvA07Wr+bzM_bwOXkwfiMxng@mail.gmail.com>
References: <9570D903A3BECE4092E924C2985CE485612B3B48@MBX202.domain.local>
 <5073328D.5000002@gmail.com> <50735165.8010703@aaronholmes.net> <CAEPJdu=pRSDRD68t3o7XVbWRo-FvA07Wr+bzM_bwOXkwfiMxng@mail.gmail.com>
Date: Mon, 8 Oct 2012 15:31:48 -0700
Message-ID: <CACxA8bkF0EHDs3As=kMcg-BahRfBK6A5i7B9TdRc_SweCsv23A@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Aaron Holmes <aaron@aaronholmes.net>, internals@lists.php.net
Content-Type: multipart/alternative; boundary=e89a8ff1c146b7b22104cb93caf4
Subject: Re: [PHP-DEV] [RFC] Propety Accessors v1.1
From: tbprogrammer@gmail.com (Jazzer Dane)

--e89a8ff1c146b7b22104cb93caf4
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I agree.
It's more consistent than the $Hours solution and we don't have to add
another superglobal or magic constant, which is quite nice. The typehinting
is a big plus as well.

On Mon, Oct 8, 2012 at 3:26 PM, Benjamin Eberlei <kontakt@beberlei.de>wrote=
:

> The set() one is really nice with the typehints.
>
> On Tue, Oct 9, 2012 at 12:19 AM, Aaron Holmes <aaron@aaronholmes.net>
> wrote:
>
> > On 10/8/12 1:07 PM, Denis Portnov wrote:
> >
> >> 08.10.2012 15:52, Clint Priest =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
> >>
> >>>      public $Hours {
> >>>          get { return $this->Seconds / 3600; }
> >>>          set { $this->Seconds =3D $value; }
> >>>          isset<http://www.php.net/isset**>  { return isset<
> >>> http://www.php.net/isset**>($this->Seconds); }
> >>>          unset<http://www.php.net/unset**>  { unset<
> >>> http://www.php.net/unset**>($this->Seconds); }
> >>>      }
> >>>
> >>
> >>
> >> Hi Clint,
> >>
> >> I've noticed some magic variable '$value' is introduced. And except fo=
r
> >> superglobals I guess there is no such thing in PHP, so it looks bit
> >> puzzling to me. I'd suggest on of the following:
> >>
> >>
> >> - setter resambles setter method, wich also allows typehinting
> >>     public $Hours {
> >>         set ($value) { $this->Seconds =3D $value * 3600; }
> >>     }
> >>
> >>     public $Hours {
> >>         set (DateTime $dateTime) { $this->Seconds =3D
> >> $dateTime->getTimestamp(); }
> >>     }
> >>
> >>  This seems like the cleanest method, in my opinion. Javascript does
> this
> > for object prototypes:
> > http://ejohn.org/blog/**javascript-getters-and-**setters/<
> http://ejohn.org/blog/javascript-getters-and-setters/>
> >
> >
> >>
> >> What do you think?
> >>
> >> Thanks
> >> Denis
> >>
> >>
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>

--e89a8ff1c146b7b22104cb93caf4--