Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63286
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain beberlei.de from 209.85.217.170 cause and error)
MIME-Version: 1.0
In-Reply-To: <50735165.8010703@aaronholmes.net>
References: <9570D903A3BECE4092E924C2985CE485612B3B48@MBX202.domain.local>
	<5073328D.5000002@gmail.com>
	<50735165.8010703@aaronholmes.net>
Date: Tue, 9 Oct 2012 00:26:59 +0200
Message-ID: <CAEPJdu=pRSDRD68t3o7XVbWRo-FvA07Wr+bzM_bwOXkwfiMxng@mail.gmail.com>
To: Aaron Holmes <aaron@aaronholmes.net>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=f46d04083a8b46ee3f04cb93b8fa
Subject: Re: [PHP-DEV] [RFC] Propety Accessors v1.1
From: kontakt@beberlei.de (Benjamin Eberlei)

--f46d04083a8b46ee3f04cb93b8fa
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

The set() one is really nice with the typehints.

On Tue, Oct 9, 2012 at 12:19 AM, Aaron Holmes <aaron@aaronholmes.net> wrote=
:

> On 10/8/12 1:07 PM, Denis Portnov wrote:
>
>> 08.10.2012 15:52, Clint Priest =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>
>>>      public $Hours {
>>>          get { return $this->Seconds / 3600; }
>>>          set { $this->Seconds =3D $value; }
>>>          isset<http://www.php.net/isset**>  { return isset<
>>> http://www.php.net/isset**>($this->Seconds); }
>>>          unset<http://www.php.net/unset**>  { unset<
>>> http://www.php.net/unset**>($this->Seconds); }
>>>      }
>>>
>>
>>
>> Hi Clint,
>>
>> I've noticed some magic variable '$value' is introduced. And except for
>> superglobals I guess there is no such thing in PHP, so it looks bit
>> puzzling to me. I'd suggest on of the following:
>>
>>
>> - setter resambles setter method, wich also allows typehinting
>>     public $Hours {
>>         set ($value) { $this->Seconds =3D $value * 3600; }
>>     }
>>
>>     public $Hours {
>>         set (DateTime $dateTime) { $this->Seconds =3D
>> $dateTime->getTimestamp(); }
>>     }
>>
>>  This seems like the cleanest method, in my opinion. Javascript does thi=
s
> for object prototypes:
> http://ejohn.org/blog/**javascript-getters-and-**setters/<http://ejohn.or=
g/blog/javascript-getters-and-setters/>
>
>
>>
>> What do you think?
>>
>> Thanks
>> Denis
>>
>>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--f46d04083a8b46ee3f04cb93b8fa--