Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63183
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <177BEC05-2944-441A-98FE-7A456061C4EE@strojny.net>
References: <177BEC05-2944-441A-98FE-7A456061C4EE@strojny.net>
Date: Thu, 20 Sep 2012 10:02:35 +0200
Message-ID: <CAEZPtU4cSGkWhcyJpEVhBUJxnrXWHyLhYFDLsgFzSpdzHqQu-g@mail.gmail.com>
To: Lars Strojny <lars@strojny.net>
Cc: "internals@lists.php.net PHP internals" <internals@lists.php.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PR 186: external protocols and locale independent
 string conversion
From: pierre.php@gmail.com (Pierre Joye)

hi Lars,

On Wed, Sep 19, 2012 at 8:35 PM, Lars Strojny <lars@strojny.net> wrote:

> I'm currently working on https://github.com/php/php-src/pull/186, which f=
ixes a problem with PostgreSQL when passing a float to pg_query_params() wi=
th a locale setting that uses "," as a decimal point. pg_query_params() use=
s convert_to_string(), which uses %G as a format string for floats, which i=
s locale sensitive (and therefore converts e.g. in hr_HR or de_DE to "1,1")=
. The proposed fix is to introduce a new API convert_to_cstring() in the Ze=
nd Engine to allow converting types to C-locale strings.
>
> This kind of fix is very likely needed in other places, where floats are =
converted using convert_to_string(). I haven=92t found time to try e.g. mys=
qlnd, but I suspect we=92ll find similar issues there. I don=92t think the =
proposed workaround of burden users with explicitly converting floats to a =
numeric representation is a good solution and I think we should fix bugs li=
ke that in places they occur.
>
> What=92s your take on the proposed fix of introducing convert_to_cstring(=
) and using it where external protocols require a locale insensitive float =
conversion?

To me it looks like it is not something we should try to solve. The
application, database code (via connection options, queries, etc.)
should take care of.

About internals other usages, *printf functions allow to do what you
suggest easily without adding yet another conversion function.

Cheers,
--=20
Pierre

@pierrejoye