Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:63137
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CALwr1GnjjjMbK8-VkVO57meDAgDn8PSPoWdj2DjYMB7F01dP4Q@mail.gmail.com>
References: <CAO1hux8mmUsy4badiNjxTGMubaduD1gkgbw4ZK1Me_MwGwLybA@mail.gmail.com>
	<CALtuQzC4e2Sn_BHinFAPdVrz8Oc_d6wCqTr=AscMChH29NSENw@mail.gmail.com>
	<CAO1hux9+4QK2sVX9+4110ksa9qDpUpfDhFJvyzkXcBHrFoFWvg@mail.gmail.com>
	<0960EAA5-17FF-4E0F-9DDE-BB93D13EA02B@gmail.com>
	<CAO1hux9t9refYHYnKhY0725MvRm88ab85Ng23LCvnjDJxqQA7g@mail.gmail.com>
	<CALwr1GnjjjMbK8-VkVO57meDAgDn8PSPoWdj2DjYMB7F01dP4Q@mail.gmail.com>
Date: Wed, 19 Sep 2012 15:10:20 +0100
Message-ID: <CAPwsocGs=5-JfpSSewDRaNC0KaoNF1okBD8-E27fx5U=9f6sgw@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Re: RFC: Implementing a core anti-XSS escaping class
From: leight@gmail.com (Leigh)

>> I missed the encoding parameter. While it's still possible to add that
>> to a static-only class, that would be more cumbersome and less correct
>> than instantiation (since the encoding is state, technically). My
>> apologies. Carry on ;-)

It's probably already been covered, but I don't like the fact that
it's a class at all.

There's nothing wrong with an ini value to start with (defaulting to X
if it is unrecofnised), then ini_set() to change the value at runtime
if required, and finally implementing everything as normal functions
that accept an override encoding as an optional parameter for those
one-off cases.

It feels like this is just using classes for the sake of using
classes, adding an unnecessary layer of complexity (and discussion)
for no real reason except that is the RFC authors preference.