Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:631
Return-Path: <chregu@bitflux.ch>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 94384 invoked from network); 3 Apr 2003 10:21:37 -0000
Received: from unknown (HELO bambi.bitflux.ch) (212.71.97.156)
  by pb1.pair.com with SMTP; 3 Apr 2003 10:21:37 -0000
Received: from lappi (gate.bitflux.ch [212.71.98.109])
	by bambi.bitflux.ch (Postfix) with ESMTP
	id 040C44CDE; Thu,  3 Apr 2003 12:21:37 +0200 (CEST)
To: Rob Richards <rrichards@digarc.com>
Cc: php-dev <internals@lists.php.net>
In-Reply-To: <00cc01c2f9c3$d71287d0$06dea8c0@cyberware.local>
References: <1048001497.1516.3.camel@localhost.localdomain>
	 <001901c2ed6f$b3be6f70$0301a8c0@TRABAJOS2>
	 <016701c2f156$f6d83080$06dea8c0@cyberware.local>
	 <Pine.LNX.4.53.0303231809291.5087@zaneeb.brainnet.i>
	 <004001c2f704$ceee0370$06dea8c0@cyberware.local>
	 <20030331181825.GB32131@schnuffel.thieso.net>
	 <00cc01c2f9c3$d71287d0$06dea8c0@cyberware.local>
Content-Type: text/plain
Organization: Bitflux GmbH
Message-ID: <1049365296.4328.22.camel@lappi.lappi.chregu.tv>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.3 
Date: 03 Apr 2003 12:21:36 +0200
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] patch: domxml - set_attirubte_node implmentation
From: chregu@bitflux.ch (Christian Stocker)

On Thu, 2003-04-03 at 11:31, Rob Richards wrote:
> Here is a patch for domxml which implements the set_attribute_node method.
> 
> Located at: http://www.digarc.com/php_domxml.diff
> 
> One thing to note is in the section where an attribute already exists. As
> there can't be dunplicate attributes, only the content from the new
> attribute node is moved to the existing attribute node. Unlinking the
> origional attribute node could potential cause a memory leak as it may never
> be freed.

Commited and thanks

chregu