Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:6283
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Mon, 8 Dec 2003 14:11:07 +0300
To: "Thies C.Arntzen" <thies@thiesos.org>
Cc: internals@lists.php.net
Message-ID: <20031208141107.66d1281c.tony2001@phpclub.net>
In-Reply-To: <B7948042-296B-11D8-888A-000393C4A12A@thiesos.org>
References: <20031205163044.130c88ed.tony2001@phpclub.net>
	<006f01c3bb34$efb22970$8802a8c0@obsidian>
	<20031205170502.0A3F.MAXIM@maxim.cx>
	<20031205190223.14724165.tony2001@phpclub.net>
	<5029FB84-27C0-11D8-AD6A-000393C4A12A@thiesos.org>
	<20031208121206.6e6d42c3.tony2001@phpclub.net>
	<B7948042-296B-11D8-888A-000393C4A12A@thiesos.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] for oci8 and some improvement proposals
From: tony2001@phpclub.net (Antony Dovgal)

On Mon, 8 Dec 2003 11:46:02 +0100
"Thies C.Arntzen" <thies@thiesos.org> wrote:

> Am 08.12.2003 um 10:12 schrieb Antony Dovgal:
> >
> > so should I add oci_lobgetlen() instead of OCILobGetLength calls after 
> > this statement?
> > or this code is considered to be working and should not be changed 
> > anymore?
> >
> > and what about deprecating old syntax, that doesn't meet naming 
> > conventions?
> >
> 
> i don't think we should break the current style. so just use 
> "OCILobGetLength" and 

It seems, that you misunderstood me.
I meant this:
Almost every function, that deals with Lobs, calls OciLobGetLength every time it's being called.
And I propose to use oci_lobgetlen(), which will decide - is it necessary to call OciLobGetLength or we can get length from Lob's descriptor.

> - if you feel like it - then change all the 
> function names to match the std naming-conventions but keep the old 
> names as aliases for bc.

ok, it's obvious.

> as jani has taken me out of the MAINTAINER file (without asking me)  
> you're welcome to take over maintainership for this piece of code. i'd 
> be willing to assist you if you have any questions.

indeed, oci8 extension is marked as orphaned ATM..
but for some reasons I thought, that you and Maxim are current maintainers of it.
and I don't think I'm currently able to maintain it (especially without your and Maxim active help).

> quick note about deprecating "old" syntax: we have a long history of 
> keeping deprecated things in forever. would you change functions names 
> in a big php-site you have created just for the sake of it? i  
> certainly woudn't. don't get me wrong, if you want to create new names 
> for the functions that's fine by me, but make _very_ sure you don't 
> screw people.

I suppose, it's a kind of deprecation, that will last till PHP6 =)

---
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net