Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6281 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92626 invoked by uid 1010); 8 Dec 2003 09:12:40 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 92592 invoked from network); 8 Dec 2003 09:12:39 -0000 Received: from unknown (HELO is.magroup.ru) (213.147.47.162) by pb1.pair.com with SMTP; 8 Dec 2003 09:12:39 -0000 Received: from grp-dovgal.MEDIA-ARTS.RU ([192.168.3.226]) by is.magroup.ru with Microsoft SMTPSVC(5.0.2195.5329); Mon, 8 Dec 2003 12:12:06 +0300 Date: Mon, 8 Dec 2003 12:12:06 +0300 To: internals@lists.php.net Message-ID: <20031208121206.6e6d42c3.tony2001@phpclub.net> In-Reply-To: <5029FB84-27C0-11D8-AD6A-000393C4A12A@thiesos.org> References: <20031205163044.130c88ed.tony2001@phpclub.net> <006f01c3bb34$efb22970$8802a8c0@obsidian> <20031205170502.0A3F.MAXIM@maxim.cx> <20031205190223.14724165.tony2001@phpclub.net> <5029FB84-27C0-11D8-AD6A-000393C4A12A@thiesos.org> X-Mailer: Sylpheed version 0.9.7cvs5 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 08 Dec 2003 09:12:06.0328 (UTC) FILETIME=[59DC8380:01C3BD6B] Subject: Re: [PHP-DEV] [PATCH] for oci8 and some improvement proposals From: tony2001@phpclub.net (Antony Dovgal) On Sat, 6 Dec 2003 08:46:33 +0100 "Thies C.Arntzen" wrote: > > Am 05.12.2003 um 17:02 schrieb Antony Dovgal: > > feel free to improve it, remember open source is not about moaning > about the quality of other ppls code, but to contribute. I'm just arguing for and not moaning =) > BTW: i have no idea what you are talking about, sure i would do things > different now - but it works today and another quote starts with "never > change..." so should I add oci_lobgetlen() instead of OCILobGetLength calls after this statement? or this code is considered to be working and should not be changed anymore? and what about deprecating old syntax, that doesn't meet naming conventions? --- WBR, Antony Dovgal aka tony2001 tony2001@phpclub.net