Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62774
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain outlook.com designates 65.54.190.222 as permitted sender)
Message-ID: <BAY002-W1314D2F2E800B12EBE7CFA48CAA0@phx.gbl>
Content-Type: multipart/alternative;
	boundary="_8c18bd65-6f33-48d3-852a-ca24fb856b44_"
To: Pierre Joye <pierre.php@gmail.com>, Derick Rethans <derick@php.net>
CC: Stas Malyshev <smalyshev@sugarcrm.com>, Gustavo Lopes
	<glopes@nebm.ist.utl.pt>, PHP internals <internals@lists.php.net>, Nikita
 Popov <nikita.ppv@gmail.com>
Date: Mon, 3 Sep 2012 18:19:46 -0700
Importance: Normal
In-Reply-To:
 <CAEZPtU63KZL7O1JwnCZW03L34N34s4BC3x4Yi=9_PfoM7=_mRw@mail.gmail.com>
References:
 <CAF+90c_7q5MJzTMt3O6tphfps5=dtxuubWigEjg4eqGwU40sRA@mail.gmail.com>,<CAF+90c8cC=U012u0SaNYQFUKgwJ_3ceTmGSQA5Esug8Yyj--hQ@mail.gmail.com>,<op.wjyx93rtidpuyk@damnation.nl.lo.geleia.net>,<5042BA76.1000100@sugarcrm.com>,<alpine.DEB.2.02.1209021809210.25835@whisky.home.derickrethans.nl>,<CAEZPtU63KZL7O1JwnCZW03L34N34s4BC3x4Yi=9_PfoM7=_mRw@mail.gmail.com>
MIME-Version: 1.0
Subject: RE: [PHP-DEV] Re: [VOTE] Generators
From: v-mafick@outlook.com (Matt Ficken)

--_8c18bd65-6f33-48d3-852a-ca24fb856b44_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I have created a single build combining the Generator RFC and the property =
getter/setter RFC.
=20
On Windows=2C one of the Generator tests fails (tests\generators\clone_with=
_stack.phpt)=2C but all pass on Linux. There are some regressions due to th=
e branch not included many of the recent fixes for Windows.=20
=20
The PHP on Windows releases are now built with Profile-Guided-Optimization(=
PGO) which optimizes compiled code for better performance in frequently use=
d blocks.=20
=20
I have also created a PGO build that combines both RFCs. It has the same pa=
ss rate as the first=2C non-PGO build of both RFCs.
=20
I have posted the binary builds=2C source code and output from run-test her=
e: http://131.107.220.66/build/RFC/
=20
Implementing both RFCs together along with PGO on Windows works well enough=
 for both RFCs to be implemented in php-next.
=20
Cheers
-Matt

=20

> Date: Mon=2C 3 Sep 2012 09:52:10 +0200
> From: pierre.php@gmail.com
> To: derick@php.net
> CC: smalyshev@sugarcrm.com=3B glopes@nebm.ist.utl.pt=3B internals@lists.p=
hp.net=3B nikita.ppv@gmail.com
> Subject: Re: [PHP-DEV] Re: [VOTE] Generators
>=20
> hi Derick=2C
>=20
> On Sun=2C Sep 2=2C 2012 at 7:10 PM=2C Derick Rethans <derick@php.net> wro=
te:
> > On Sat=2C 1 Sep 2012=2C Stas Malyshev wrote:
> >
> >> > illegal state was written on the RFC when voting opened=2C and the R=
FC
> >> > was accepted almost unanimously. As the proposal was accepted as
> >> > such=2C I saw no valid reason not to merge. In fact=2C changing the
> >> > proposal after it was voted on would be much more objectionable.
> >>
> >> I definitely did not agree to using exceptions=2C though I support the
> >> rest of it.
> >
> > Same here.
> >
> >> I'm completely fine with merging it but just for the record I'd like
> >> to note that accepting it doesn't mean we will not tweak it or change
> >> some fine details of it - like how we handle some error situations.
> >
> > Right=2C so lets remove that exception throwing!
>=20
> Let clear that topic once and for all (almost) instead.
>=20
> I think some guidance to help to chose on a case by base whether
> exceptions should be used or not. Let discussion that in the other
> thread.
>=20
> Cheers=2C
> --=20
> Pierre
>=20
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe=2C visit: http://www.php.net/unsub.php
>=20
 		 	   		  =

--_8c18bd65-6f33-48d3-852a-ca24fb856b44_--