Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:6270 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71945 invoked by uid 1010); 7 Dec 2003 14:39:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 71870 invoked from network); 7 Dec 2003 14:39:49 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 7 Dec 2003 14:39:49 -0000 Received: from [10.21.1.187] (c38047.upc-c.chello.nl [212.187.38.47]) by jdi.jdimedia.nl (8.12.10/8.12.10) with ESMTP id hB7Edln9006506; Sun, 7 Dec 2003 15:39:47 +0100 Date: Sun, 7 Dec 2003 15:39:47 +0100 (CET) X-X-Sender: derick@localhost To: Rasmus Lerdorf cc: Antony Dovgal , internals@lists.php.net In-Reply-To: Message-ID: References: <20031201172641.15c2508b.tony2001@phpclub.net> <20031201190249.64cff2d0.tony2001@phpclub.net> <20031201193408.1fed4ba4.tony2001@phpclub.net> <20031201164526.34822.qmail@pb1.pair.com> <20031201172135.5033.qmail@pb1.pair.com> <20031201211802.408f546e.tony2001@phpclub.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] HEAD eats all memory (solved?) From: derick@php.net (Derick Rethans) On Mon, 1 Dec 2003, Rasmus Lerdorf wrote: > On Mon, 1 Dec 2003, Derick Rethans wrote: > > > On Mon, 1 Dec 2003, Rasmus Lerdorf wrote: > > > > > Derick, looking at the code it looks like we are checking for the a= case > > > and handling that correctly, but not the =a case. As in foo.com?a= vs > > > foo.com?=a > > > > That is something I did not touch, but I found the problem which caused > > this...forgot to change the default sapi input filter handler to return > > new_val_len. I'll have a look at the =a case (what should this do?) > > It should skip the variable. No problems here, as safe_php_register_variable calls php_register_variable, which calls php_register_variable_safe, which calls php_register_variable_ex which has this code in there: /* ignore leading spaces in the variable name */ while (*var && *var==' ') { var++; } var_len = strlen(var); if (var_len==0) { /* empty variable name, or variable name with a space in it */ zval_dtor(val); return; } Derick