Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62611
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAH-PCH5TM2ag-5xm3Rk7Ef6LnpEst1UqRoc_f_Uwp_aLe418dA@mail.gmail.com>
References: <AANLkTimWuPXCs-HT6RgQYmH7UKcOYXkeTiMEnBwBXxnt@mail.gmail.com>
	<CAH-PCH4YdBr7WfQ2PR0_Fr_C=TfBsSGsbX3G-jonUqyfLrCcZQ@mail.gmail.com>
	<5040DC47.8000305@ajf.me>
	<CAH-PCH5TM2ag-5xm3Rk7Ef6LnpEst1UqRoc_f_Uwp_aLe418dA@mail.gmail.com>
Date: Fri, 31 Aug 2012 13:03:15 -0400
Message-ID: <CAAyV7nEnOWbM9H03OUgSC=0ZhhDF4OjxACR32vK10uYKrv-WVg@mail.gmail.com>
To: Ferenc Kovacs <tyra3l@gmail.com>
Cc: Andrew Faulds <ajf@ajf.me>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d0434bfde97c35204c892c439
Subject: Re: [PHP-DEV] Re: Are exceptions allowed in php core?
From: ircmaxell@gmail.com (Anthony Ferrara)

--f46d0434bfde97c35204c892c439
Content-Type: text/plain; charset=ISO-8859-1

Ferenc,

>>  Not for PHP 5.5 (if that's happening?), but for PHP 6 I think a lot of
> > things should become exceptions.
>
>
> From the impression that I get from reading through the mailing list
> threads and the irc discussions I think that there aren't that many things
> that could turn into exceptions.
> E_RECOVERABLE_ERROR and probably that's it.


Actually, from my look at it, almost all E_WARNINGs, a number of E_NOTICEs
(the ones that make sense to transition, like array to string cast),
E_RECOVERABLE and certain E_ERROR (such as call to undefined method, etc)
can be turned pretty easily. The ones that can't (without significant
change to the engine at least) are deeper E_ERROR, E_CORE_*, and E_PARSE...

Take a look at the library I am linking to deeper down. All of those errors
are core thrown errors that can be easily turned into exceptions. Plus the
E_ERROR that I couldn't, but we can in core (again, call to undefined
method, etc)...


> > I don't think that, personally, PHP's current error handling system is
> > sufficient for properly handling errors.
>
>
> It is working for years, it could be improved but I wouldn't call it
> insufficient.


Any system where it's **harder** to handle the error properly than to
ignore it is insufficient in my book. The fact that you need something like
this: https://github.com/ircmaxell/ErrorExceptions to handle errors
properly as exceptions (to be notified not that an error occured, but the
type of error) is indicative of that...

Anthony

--f46d0434bfde97c35204c892c439--