Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:62536 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69961 invoked from network); 26 Aug 2012 21:32:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Aug 2012 21:32:08 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 74.125.82.48 mail-wg0-f48.google.com Received: from [74.125.82.48] ([74.125.82.48:38589] helo=mail-wg0-f48.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id CF/7D-00843-8D59A305 for ; Sun, 26 Aug 2012 17:32:08 -0400 Received: by wgbdq11 with SMTP id dq11so2590773wgb.29 for ; Sun, 26 Aug 2012 14:32:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=RTf0CbtLtyZh6wZTk4OOFUXJ4cD/3bofeZkyax0S0BE=; b=TSxiX0gGTF1Gdmf39TV10VYua4KCsETPr4hRCHDz5phZB+oWzIrFoKqnIX4AgSO6vN Neih4dO85AlniWHQYVtsXxDGiJ5ce2WEGb74tjMW1hPFkWNmH0Zd7kVM0BLCrU4p9Mx6 o0NuTJhUivWt42tHPSORmDnAS3DF4BGufl3V/6inDI2mKBNbNQQAK3/18k4Eu12Wh+zr RYUp62b3uImYLZiY1Etk1qVp+c/Dk3Jd0PqlxOqSF1ehfkG5RrUoUuGL6kMwjF8oOkgX vsTa+Q87dVFeCjBEc7VvR7Dps+JoBiOUpqPu8ZitZErxVBKE2jkzpba09fz/IdnonAxB mqCw== Received: by 10.216.181.195 with SMTP id l45mr5788018wem.52.1346016725418; Sun, 26 Aug 2012 14:32:05 -0700 (PDT) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.223.86.201 with HTTP; Sun, 26 Aug 2012 14:31:25 -0700 (PDT) In-Reply-To: References: <50364644.1060302@lerdorf.com> <5039D249.30707@sugarcrm.com> Date: Mon, 27 Aug 2012 06:31:25 +0900 X-Google-Sender-Auth: m8vfJ3m_F1K_Wd06_B7_MAClC0g Message-ID: To: Stas Malyshev Cc: Sherif Ramadan , PHP Internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Session Id Collisions From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi, 2012/8/27 Yasuo Ohgaki : > Hi, > > 2012/8/26 Stas Malyshev : >> Hi! >> >>> What's the status of session adoption patch? >>> I've created patches for all 3 versions and I think Stats >>> is going to merge it to master and PHP 5.4. >> >> As far as I remember there were some things that needed to be >> refactored/changed and I didn't see the updates since then, but if you >> could point me to the latest version I could check it out. > > We agreed not to introduce new session save handler API so that > there would be no barrier for adoption. > > I've done it months ago, I guess you missed a mail. > These are the patch. > > master > https://gist.github.com/1379668 > > 5.4 > https://gist.github.com/2224196 > > 5.3 > https://gist.github.com/2224360 > > There might be conflict since it's made at 3/28, I'll > fix it if there is. (I'll check it myself within a few days) > >> if you >> could point me to the latest version I could check it out. > > Thank you for your time. > > Regards, It seems I've already added collision detection when I last updated :) It tries to generate new session ID a few times and if it fails, it does not initialize session. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net