Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:62418 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27324 invoked from network); 23 Aug 2012 11:55:20 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Aug 2012 11:55:20 -0000 Authentication-Results: pb1.pair.com smtp.mail=ondrej@sury.org; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ondrej@sury.org; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sury.org designates 209.85.214.170 as permitted sender) X-PHP-List-Original-Sender: ondrej@sury.org X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com Received: from [209.85.214.170] ([209.85.214.170:53923] helo=mail-ob0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 24/F4-29773-72A16305 for ; Thu, 23 Aug 2012 07:55:20 -0400 Received: by obbwc18 with SMTP id wc18so1453536obb.29 for ; Thu, 23 Aug 2012 04:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sury.org; s=google; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=TOyBPMby3e69NajfdQmgaO3/lV6ObLfqlHVFebmdZfY=; b=QGcinTJ9Qh9sk1Q40kehsMVfX0KcJLPWUri9OH49LN+dEVes/yUoaMChQdeVoeSKFB SLf5echfjn87HT9jn8dNMJCvFdvzpwKSNssD1wCB2vncEsRdAoxj0nb5qix9b+VdWGJD 33hNGIs2RDiX+TNBUOlkK8tzofgg/VJmyb8H0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding:x-gm-message-state; bh=TOyBPMby3e69NajfdQmgaO3/lV6ObLfqlHVFebmdZfY=; b=Pu8ujruakgp64BDR4ygX492OmNRukSXaxoDWrz/CVaRQwWtBqJSkocnDFctJbQpzyH 0VfT+wy/v8EpIB8psykr03Tblsdhsoq+l0qLqUawDdU/CuQMvYS/JS8RJv9HMpxK1Xj0 itwcxvl8+NGwpyX5obuzEXLtKzoR7+FNzC4JxG70wt0bDW29BRtYp1vespBn6kcMWbzg doE8I5iuziEiCQT4etpkF2n6a7p4I6rwTfPqOMJoE/mYOxxBCbjNEixBbRFo32J8vlD5 DlV+9B5cKr+hDVDSFQeD8aa6zFWqyTVkRyuZ65vI4pFp5WOhqcSLgrpCwn43wx6IyyCz uEnA== Received: by 10.60.12.37 with SMTP id v5mr836742oeb.25.1345722916707; Thu, 23 Aug 2012 04:55:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.60.18.164 with HTTP; Thu, 23 Aug 2012 04:54:56 -0700 (PDT) Date: Thu, 23 Aug 2012 13:54:56 +0200 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQkKb4PlpHjj3W486+2a7WNchfWHxhIakpCNnxnKcag+aGx+iOJWfFHF1w9/j+V8MPmC7lZU Subject: PHP#62227 (Invalid phar stream path causes crash) was not present in 5.4 From: ondrej@sury.org (=?UTF-8?B?T25kxZllaiBTdXLDvQ==?=) Hi, this is a documentation bug only which I have discovered when cherry-picking patches in 5.4.5 and 5.4.6. PHP Bug #62227 was never present in PHP 5.4 due changes in the code commite= d in: commit dd5c478be61a0ef94b54837cfa875c964356e14f Author: Dmitry Stogov Date: Tue Apr 20 11:05:54 2010 +0000 Added concept of interned strings. All strings constants known at compile time are allocated in a single copy and never changed. And the merge of 15213768 didn't change the affected code. Also the test case in the bugreport doesn't segfault in 5.4.4. Should I fill bug report even for such small nit? (I could.) Simple patch: diff --git a/NEWS b/NEWS index de19a20..8049d5b 100644 --- a/NEWS +++ b/NEWS @@ -168,9 +168,6 @@ PHP NEWS . Fixed bug #62266 (Custom extension segfaults during xmlParseFile with = FPM SAPI). (Gustavo) -- Phar: - . Fixed bug #62227 (Invalid phar stream path causes crash). (Felipe) - - Readline: . Fixed bug #62186 (readline fails to compile - void function should not return a value). (Johannes) O. --=20 =EF=BB=BFOnd=C5=99ej Sur=C3=BD