Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62384
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAFMT4NrQJRVbZefMxzss0aqEZxZbWtsDX0g4fBtnzpmrTv0+tQ@mail.gmail.com>
References: <CADqTB_hbCQxBJNf6moNqMaCBK5UzpXk_zg64qRFjv-5npXio9A@mail.gmail.com>
 <CAGa2bXbK+-CYe9E2gnwfwrHqpuGEpX2YLJ8Gnugt7CjxJnbaog@mail.gmail.com> <CAFMT4NrQJRVbZefMxzss0aqEZxZbWtsDX0g4fBtnzpmrTv0+tQ@mail.gmail.com>
Date: Wed, 22 Aug 2012 11:13:47 +0900
Message-ID: <CAGa2bXbDNaKcezSK6x4DBnPWyQep0AHTqXG-TOT003Tnx1HFhg@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Rasmus Schultz <rasmus@mindplay.dk>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] removing an item from an array
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi,

2012/8/22 Levi Morrison <morrison.levi@gmail.com>:
> On Tue, Aug 21, 2012 at 7:45 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>>
>> Hi,
>>
>> 2012/8/16 Rasmus Schultz <rasmus@mindplay.dk>:
>> > How come there is no straight-foward obvious way to simply remove a gi=
ven
>> > value from an array?
>> >
>> > Just look at the number of horrible ways people solve this obvious pro=
blem:
>> >
>> > http://stackoverflow.com/questions/7225070/php-array-delete-by-value-n=
ot-key
>> >
>> > Shouldn't we have something simple, like:
>> >
>> >     array_remove($array, $value) : array (returns a new array)
>> >
>> > and/or
>> >
>> >     array_delete(&$array, $value) : bool (modifies array directly)
>> >
>> > ?
>>
>> It was amazing that this thread has close to 90 mails.
>>
>> I've added some use cases of array_udelete() to wiki, since
>> some people fails to see how it could be useful. I also bring
>> back to array_walk() version of equivalent example. I just
>> don't see any reason why we should replace it with slower
>> foreach() version.
>>
>> I think the RFC page is almost complete.
>>
>> https://wiki.php.net/rfc/array_delete
>>
>> Any more comments?
>>
>> --
>> Yasuo Ohgaki
>> yohgaki@ohgaki.net
>
> Take a look at:
> http://php.net/manual/en/function.array-walk.php#refsect1-function.array-=
walk-parameters
>
> Look at funcname parameter.  Notice:
>> Only the values of the array may potentially be changed; its structure c=
annot be altered, i.e., the programmer cannot add, unset or reorder element=
s. If the callback does not respect this requirement, the behavior of this =
function is undefined, and unpredictable.
>
> I'm just going to change the behavior back when you switch it to
> array_walk. It's less clear and technically undefined.

Ok, then my commit to the doc was outstanding still.
Old PHP was behaved badly with reference variables.
I'll remove obsolete statement.

I'll fix it later.
Thank you.

--
Yasuo Ohgaki
yohgaki@ohgaki.net