Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62378
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.182 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAFMT4NoqGiZ7JStahLVw-4OH47Y99QYELgOZ3wLbo_OvFK_J3w@mail.gmail.com>
References: <CADqTB_jyk7e8oZzxUQ42JA9PGjzgydddmsfwNx+6F-wD96mv6Q@mail.gmail.com>
 <CAArmra1XSnbQLSikM5yfhtYOtdZHNdwG5r1dAD6NmqVGO2St5w@mail.gmail.com>
 <CADqTB_iPJjPcQk9n_K3O5ccTMhkStw0Mw6GxSwFXYEuZ5tvbfQ@mail.gmail.com>
 <CAGa2bXbFyX0ienu2O4tn2Rn=2i2e-TG4YL9-4gnTjJxYTooKNA@mail.gmail.com>
 <CADqTB_hsMf6q8tdv9yzHTvkEqSjGPqWferJMv5Xx973iyQuP4A@mail.gmail.com>
 <CAHMUw2HE+ycKf0Mw5AFb7S37bi0dbSsFBwtM3wejGu6gfcgG-w@mail.gmail.com>
 <CAGa2bXarvVyzdg2npvyhRUTM+dDx_qB-M8y=PsjzNhJ_U57xvw@mail.gmail.com>
 <5033E0BC.8040507@ajf.me> <CAGa2bXYpyStxy=XstOiA1HLvx11naWB1kciX08o0kLKcptheEg@mail.gmail.com>
 <5033EAAB.6090502@ajf.me> <CAGa2bXaGMekwGw5FwPcRQ5wQdGBLvNJDMrooUxOn-Ca94D0AHA@mail.gmail.com>
 <5033F1EA.4070701@ajf.me> <CAGa2bXa7JRM08u8h0HnTny+Lx6in9-nQtS0x7cHGqa6kr=o9xw@mail.gmail.com>
 <5033FD9C.6080106@ajf.me> <CAGa2bXYfqUYG3z+4huptZj2BMkZ7y5GWAYb1XyGzRm00-Yw2oQ@mail.gmail.com>
 <5033FF96.5030105@ajf.me> <CAFMT4NrepX-gT60f_kzA5VKF4Uses1qT6fBiKawqv7QVtKpE_A@mail.gmail.com>
 <5034017E.1020002@ajf.me> <CAFMT4No50EN5UwWAm1814=jyOXAyRk0bD3K0+CoyJUWcjTLE_g@mail.gmail.com>
 <CAGa2bXacnjoOQ5+w-PwTnv5TXSeZ8yr+u+vOqcnp_0eu5VqkiA@mail.gmail.com>
 <CAGa2bXYPeZ2fs6BK2SfYmJFdp_z7DDNtSk5GTK2V1LQ0bysaHw@mail.gmail.com>
 <CAFMT4NpCbCjwAo-dqQ+qf0ooJX5VXtJijhfXDWf6QUPNqg07Sg@mail.gmail.com>
 <CAGa2bXa+wK8u+JTuOdAdaRbJduYXCqzkfqLvTBwVSiXMm5SrGw@mail.gmail.com> <CAFMT4NoqGiZ7JStahLVw-4OH47Y99QYELgOZ3wLbo_OvFK_J3w@mail.gmail.com>
Date: Wed, 22 Aug 2012 08:00:08 +0900
Message-ID: <CAGa2bXZA8EnNN3eT9vY3j2Pa4Jb=NWQqsS-bu-Xzm+6K_G9WAQ@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Andrew Faulds <ajf@ajf.me>, Tjerk Anne Meesters <datibbaw@php.net>, Rasmus Schultz <rasmus@mindplay.dk>, 
	internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] re: removing an item from an array
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

2012/8/22 Levi Morrison <morrison.levi@gmail.com>:
>> Why did you change the equivalent code?
>> array_walk is the best(fast and memory efficient) way
>> to delete elements.
>>
>> This code may be refereed from old PHP users, therefore
>> we should write better code.
>>
>> If you don' t have good reason to do so, please revert
>> the change.
>
> The implementation you had may be faster, but that is certainly NOT
> what matters as long as both are correct. What matters in the RFC is
> clarity.  You have already said that too many people don't know about
> array_walk, so why would they understand array_delete in terms of
> array_walk?  Please do not revert the change as what I have written is
> more clear.

I don't say array_walk() is difficult, but people out there
just don't know it.

Why we should use inefficient example for internals?
Besides, if array_walk() is used, people who would like
to write patch for it will knew that most of code can be
borrowed from array_walk().

Thus, it may prevent reinventing wheel.

> The reason speed doesn't matter in behavior example is that once it is
> implemented in C it will be just as fast as array_walk, perhaps it
> will even be faster.

I cannot agree to this opinion.
I still think the example should be reverted.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net