Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62374
Return-Path: <yohgaki@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 68598 invoked from network); 21 Aug 2012 22:27:35 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Aug 2012 22:27:35 -0000
Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
X-PHP-List-Original-Sender: yohgaki@gmail.com
X-Host-Fingerprint: 74.125.82.170 mail-we0-f170.google.com  
Received: from [74.125.82.170] ([74.125.82.170:61685] helo=mail-we0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id EF/BC-10139-65B04305 for <internals@lists.php.net>; Tue, 21 Aug 2012 18:27:35 -0400
Received: by weyr1 with SMTP id r1so227291wey.29
        for <internals@lists.php.net>; Tue, 21 Aug 2012 15:27:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type;
        bh=dZebnZA3HQDRHgKl9MFm5yoA6i2rs4uK+mM8tRsOVYQ=;
        b=n03MDnT/yvR0BQ4NUFJaOF0wEDfHU55VD/JZgpOkUm+FeLwr8A6uCjdZwYX6RaMjt9
         OZA7nv5nslXwSbY/3iUCqAsI/WFuyl4+/3ETYJ64YlkmVkr7ewImzPvD1YcKkVlRavZ0
         h4w6daCTeenObOEc4Ks086Xn9I/B1yBNQlq64vSZCi/ywCM7GYl+15Yp/HNodek27y5+
         rj7X7BWn0SXZnN2IJMBkP2nxmuLd9rdiLD/hueiVpDo+AwEO+rrzQGAjV1dhesUSokLx
         qeJNHxkmd+bOknKa1YhIBlFXqoSQyX67vmr91+I95/ZYH8uE/YIq8Iz1R0a1Z8MDqRxA
         cJMQ==
Received: by 10.216.192.85 with SMTP id h63mr9613103wen.7.1345588051683; Tue,
 21 Aug 2012 15:27:31 -0700 (PDT)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
Received: by 10.223.86.201 with HTTP; Tue, 21 Aug 2012 15:26:50 -0700 (PDT)
In-Reply-To: <CAFMT4NpCbCjwAo-dqQ+qf0ooJX5VXtJijhfXDWf6QUPNqg07Sg@mail.gmail.com>
References: <CADqTB_jyk7e8oZzxUQ42JA9PGjzgydddmsfwNx+6F-wD96mv6Q@mail.gmail.com>
 <CAArmra1XSnbQLSikM5yfhtYOtdZHNdwG5r1dAD6NmqVGO2St5w@mail.gmail.com>
 <CADqTB_iPJjPcQk9n_K3O5ccTMhkStw0Mw6GxSwFXYEuZ5tvbfQ@mail.gmail.com>
 <CAGa2bXbFyX0ienu2O4tn2Rn=2i2e-TG4YL9-4gnTjJxYTooKNA@mail.gmail.com>
 <CADqTB_hsMf6q8tdv9yzHTvkEqSjGPqWferJMv5Xx973iyQuP4A@mail.gmail.com>
 <CAHMUw2HE+ycKf0Mw5AFb7S37bi0dbSsFBwtM3wejGu6gfcgG-w@mail.gmail.com>
 <CAGa2bXarvVyzdg2npvyhRUTM+dDx_qB-M8y=PsjzNhJ_U57xvw@mail.gmail.com>
 <5033E0BC.8040507@ajf.me> <CAGa2bXYpyStxy=XstOiA1HLvx11naWB1kciX08o0kLKcptheEg@mail.gmail.com>
 <5033EAAB.6090502@ajf.me> <CAGa2bXaGMekwGw5FwPcRQ5wQdGBLvNJDMrooUxOn-Ca94D0AHA@mail.gmail.com>
 <5033F1EA.4070701@ajf.me> <CAGa2bXa7JRM08u8h0HnTny+Lx6in9-nQtS0x7cHGqa6kr=o9xw@mail.gmail.com>
 <5033FD9C.6080106@ajf.me> <CAGa2bXYfqUYG3z+4huptZj2BMkZ7y5GWAYb1XyGzRm00-Yw2oQ@mail.gmail.com>
 <5033FF96.5030105@ajf.me> <CAFMT4NrepX-gT60f_kzA5VKF4Uses1qT6fBiKawqv7QVtKpE_A@mail.gmail.com>
 <5034017E.1020002@ajf.me> <CAFMT4No50EN5UwWAm1814=jyOXAyRk0bD3K0+CoyJUWcjTLE_g@mail.gmail.com>
 <CAGa2bXacnjoOQ5+w-PwTnv5TXSeZ8yr+u+vOqcnp_0eu5VqkiA@mail.gmail.com>
 <CAGa2bXYPeZ2fs6BK2SfYmJFdp_z7DDNtSk5GTK2V1LQ0bysaHw@mail.gmail.com> <CAFMT4NpCbCjwAo-dqQ+qf0ooJX5VXtJijhfXDWf6QUPNqg07Sg@mail.gmail.com>
Date: Wed, 22 Aug 2012 07:26:50 +0900
X-Google-Sender-Auth: ReHFTf3RLKsa4v4_S75-uppXlt4
Message-ID: <CAGa2bXa+wK8u+JTuOdAdaRbJduYXCqzkfqLvTBwVSiXMm5SrGw@mail.gmail.com>
To: Levi Morrison <morrison.levi@gmail.com>
Cc: Andrew Faulds <ajf@ajf.me>, Tjerk Anne Meesters <datibbaw@php.net>, Rasmus Schultz <rasmus@mindplay.dk>, 
	internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] re: removing an item from an array
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi,

2012/8/22 Levi Morrison <morrison.levi@gmail.com>:
> On Tue, Aug 21, 2012 at 4:13 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>> Hi,
>>
>> I see why with new Criticism section in the wiki page.
>> You've also misunderstood that array_udelete() is
>> array_walk() variant, not array_filter().
>>
>
> Actually, array_udelete is far more similar to array_filter than it is
> array_walk. . .

Why did you change the equivalent code?
array_walk is the best(fast and memory efficient) way
to delete elements.

This code may be refereed from old PHP users, therefore
we should write better code.

If you don' t have good reason to do so, please revert
the change.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net