Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62349
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXaMizr_tK-5p1-KyHRNS_UzTNGgygPM0tkdqfqzi6tZTg@mail.gmail.com>
References: <CADqTB_jyk7e8oZzxUQ42JA9PGjzgydddmsfwNx+6F-wD96mv6Q@mail.gmail.com>
	<502EB667.1020602@lerdorf.com>
	<CAGa2bXZFK7CUyf29ieBGhntqwceG1aWBpSL6N9MSJmB396CL=Q@mail.gmail.com>
	<CACQesk6-0P43_zJanx7vm7T3gk8pkkyBz9BtUkS4STrz5Ha=nA@mail.gmail.com>
	<CAGa2bXb3Kjr+YZB5pv90wYSEMTOgEHwNkMGwBux__kbsxe+zAA@mail.gmail.com>
	<CAAUB37B8Q79br2U6-cHR0LJZOVRWA_cO4pP-ma9CevUJtq5DTg@mail.gmail.com>
	<CAGa2bXbaCdFEbCxqGQdAwrzPB7oHf1zm2PLTy-yzrSh-76DxHw@mail.gmail.com>
	<CAArmra1XSnbQLSikM5yfhtYOtdZHNdwG5r1dAD6NmqVGO2St5w@mail.gmail.com>
	<CADqTB_iPJjPcQk9n_K3O5ccTMhkStw0Mw6GxSwFXYEuZ5tvbfQ@mail.gmail.com>
	<CAGa2bXbFyX0ienu2O4tn2Rn=2i2e-TG4YL9-4gnTjJxYTooKNA@mail.gmail.com>
	<CADqTB_hsMf6q8tdv9yzHTvkEqSjGPqWferJMv5Xx973iyQuP4A@mail.gmail.com>
	<CAHMUw2HE+ycKf0Mw5AFb7S37bi0dbSsFBwtM3wejGu6gfcgG-w@mail.gmail.com>
	<CAGa2bXarvVyzdg2npvyhRUTM+dDx_qB-M8y=PsjzNhJ_U57xvw@mail.gmail.com>
	<CAFMT4NpWgzZ880pY7ajyytPKrBmL9Xfw+dY0FiVh-qg0r-tFYg@mail.gmail.com>
	<CAGa2bXaMizr_tK-5p1-KyHRNS_UzTNGgygPM0tkdqfqzi6tZTg@mail.gmail.com>
Date: Tue, 21 Aug 2012 13:00:59 -0600
Message-ID: <CAFMT4NrweKdr7aPU-mQ1P2KEUbcasVfLxVf8fD=g+RbCtO8g0w@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Tjerk Anne Meesters <datibbaw@php.net>, Rasmus Schultz <rasmus@mindplay.dk>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] re: removing an item from an array
From: morrison.levi@gmail.com (Levi Morrison)

On Tue, Aug 21, 2012 at 12:53 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> 2012/8/21 Levi Morrison <morrison.levi@gmail.com>:
>>
>> I'm against this RFC, but if you are going to even try to add
>> something, please keep it consistent! Don't modify `array_delete` to
>> take a callable, instead make a different function `array_udelete` or
>> something.
>>
>
> Original proposal is adding array_delete() and this is under discussion.
> We don't have to add array_add()
>
>> And keep default $strict values consistent with existing functions
>> that have that parameter.
>
> Users should use array_walk() when they would like to delete element(s).
> To be consistent, it should be callable.
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net

I didn't say anything about `array_add`.  I meant to say if you are
going to try to add something to the core that you need to be
consistent with the other array functions.

Why use `array_walk` to delete elements? Isn't the whole point of
`array_delete` to make that process easier?

I think you missed the whole point of my last message: keep the
functions you propose similar to ones that already exist.