Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62270
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.176 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <503171D5.6060906@ajf.me>
References: <CADqTB_jyk7e8oZzxUQ42JA9PGjzgydddmsfwNx+6F-wD96mv6Q@mail.gmail.com>
 <502EB667.1020602@lerdorf.com> <CAGa2bXZFK7CUyf29ieBGhntqwceG1aWBpSL6N9MSJmB396CL=Q@mail.gmail.com>
 <CACQesk6-0P43_zJanx7vm7T3gk8pkkyBz9BtUkS4STrz5Ha=nA@mail.gmail.com>
 <CAGa2bXb3Kjr+YZB5pv90wYSEMTOgEHwNkMGwBux__kbsxe+zAA@mail.gmail.com> <503171D5.6060906@ajf.me>
Date: Mon, 20 Aug 2012 08:16:14 +0900
Message-ID: <CAGa2bXbcJckJ2gDHdvnZDWXVB0wvQKkYZWMq14F6iempwu3kpg@mail.gmail.com>
To: Andrew Faulds <ajf@ajf.me>
Cc: Etienne Kneuss <colder@php.net>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	Rasmus Schultz <rasmus@mindplay.dk>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] re: removing an item from an array
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

2012/8/20 Andrew Faulds <ajf@ajf.me>:
> On 20/08/12 00:05, Yasuo Ohgaki wrote:
>>
>> 2012/8/20 Etienne Kneuss <colder@php.net>:
>>>
>>> On Sun, Aug 19, 2012 at 11:57 PM, Yasuo Ohgaki <yohgaki@ohgaki.net>
>>> wrote:
>>>>
>>>> 2012/8/18 Rasmus Lerdorf <rasmus@lerdorf.com>:
>>>>>
>>>>> On 08/17/2012 05:21 PM, Rasmus Schultz wrote:
>>>>>>>
>>>>>>> if(($key = array_search($del_val, $messages)) !== false) {
>>>>>>>      unset($messages[$key]);
>>>>>>> }
>>>>>>>
>>>>>>> Nothing horrible here.
>>>>>>>
>>>>>> I disagree - this is (or should be) a simple, atomic operation...
>>>>>> yet, you've got a function-call, an intermediary variable, a boolean
>>>>>> test,
>>>>>> and an unset statement repeating the name of the array you're deleting
>>>>>> from.
>>>>>>
>>>>>> This should be a simple statement or function/method-call, and in most
>>>>>> other languages it would be...
>>>>>
>>>>> Really? I can't think of a single language that has a call to remove an
>>>>> element by value in a key-value hash. Do you have some examples? What
>>>>> do
>>>>> you do with duplicates?
>>>>>
>>>> Ruby can do (using irb)
>>>>
>>>> ruby-1.9.2-p180 :007 > h = {"apple"=>150, "banana"=>300, "lemon"=>300}
>>>>   => {"apple"=>150, "banana"=>300, "lemon"=>300}
>>>> ruby-1.9.2-p180 :008 > h.delete_if { |k,v| v==300 }
>>>>   => {"apple"=>150}
>>>>
>>>> May be we should have something like
>>>>
>>>> array_delete_if($array, function($v, $k=null) { if ($v == 300) return
>>>> true; })
>>>
>>> So array_filter?
>>
>> I'll use it or like for deleting, but the point of this thread is
>> "intuitive function for deleting element(s)"
>>
>> array_delete($array, $value|callable)
>>
>> would be nicer for users, perhaps.
>
> A callable? Wouldn't that mean you couldn't delete strings? :(

If you read my previous post,  you'll see why it would be nicer with callable.

>>>> Ruby can do (using irb)
>>>>
>>>> ruby-1.9.2-p180 :007 > h = {"apple"=>150, "banana"=>300, "lemon"=>300}
>>>>   => {"apple"=>150, "banana"=>300, "lemon"=>300}
>>>> ruby-1.9.2-p180 :008 > h.delete_if { |k,v| v==300 }
>>>>   => {"apple"=>150}
>>>>
>>>> May be we should have something like
>>>>
>>>> array_delete_if($array, function($v, $k=null) { if ($v == 300) return
>>>> true; })

--
Yasuo Ohgaki