Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62225
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.220.170 cause and error)
Message-ID: <502EB667.1020602@lerdorf.com>
Date: Fri, 17 Aug 2012 17:23:51 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0
MIME-Version: 1.0
To: Rasmus Schultz <rasmus@mindplay.dk>
CC: internals@lists.php.net
References: <CADqTB_jyk7e8oZzxUQ42JA9PGjzgydddmsfwNx+6F-wD96mv6Q@mail.gmail.com>
In-Reply-To: <CADqTB_jyk7e8oZzxUQ42JA9PGjzgydddmsfwNx+6F-wD96mv6Q@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] re: removing an item from an array
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 08/17/2012 05:21 PM, Rasmus Schultz wrote:
>>
>> if(($key = array_search($del_val, $messages)) !== false) {
>>     unset($messages[$key]);
>> }
>>
>> Nothing horrible here.
>>
> 
> I disagree - this is (or should be) a simple, atomic operation...
> yet, you've got a function-call, an intermediary variable, a boolean test,
> and an unset statement repeating the name of the array you're deleting from.
> 
> This should be a simple statement or function/method-call, and in most
> other languages it would be...

Really? I can't think of a single language that has a call to remove an
element by value in a key-value hash. Do you have some examples? What do
you do with duplicates?

-Rasmus