Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:62124 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 47523 invoked from network); 13 Aug 2012 02:25:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Aug 2012 02:25:52 -0000 Authentication-Results: pb1.pair.com header.from=brian@moonspot.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=brian@moonspot.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain moonspot.net designates 72.5.90.26 as permitted sender) X-PHP-List-Original-Sender: brian@moonspot.net X-Host-Fingerprint: 72.5.90.26 mail.dealnews.com Linux 2.6 Received: from [72.5.90.26] ([72.5.90.26:42078] helo=mail.dealnews.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BE/E0-00812-EA568205 for ; Sun, 12 Aug 2012 22:25:51 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.dealnews.com (Postfix) with ESMTP id 6EF6D617B19D; Sun, 12 Aug 2012 22:25:47 -0400 (EDT) X-Virus-Scanned: amavisd-new at dealnews.com Received: from mail.dealnews.com ([127.0.0.1]) by localhost (atl-zimbra1.dealnews.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EPbHZLk4TIS4; Sun, 12 Aug 2012 22:25:46 -0400 (EDT) Received: from Brians-MacBook-Pro.local (h105.248.18.98.static.ip.windstream.net [98.18.248.105]) by mail.dealnews.com (Postfix) with ESMTPSA id 35318617B27B; Sun, 12 Aug 2012 22:25:46 -0400 (EDT) Message-ID: <502865AB.7090808@moonspot.net> Date: Sun, 12 Aug 2012 21:25:47 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Levi Morrison CC: Nikita Popov , PHP internals References: <50280D37.10109@moonspot.net> <502842C1.1070401@moonspot.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [RFC] Generators From: brian@moonspot.net (Brian Moon) >> I don't consider this a very good example. > That's fine. You are entitled to your opinion. However, you didn't > have to figure out the 106 lines of code that is the Post-Order > iterator. That was a NIGHTMARE and I'm still not 100% confident that > it works as it is supposed to. The generator, on the other hand, is > simple and follows the definition very closely. MUCH better. Could you show the whole class that this public function belongs to? I don't see how this function fits in and compares at all to the class you linked. Brian.