Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62097
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.163 as permitted sender)
Message-ID: <5023544B.3020003@sugarcrm.com>
Date: Wed, 08 Aug 2012 23:10:19 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20120713 Thunderbird/14.0
MIME-Version: 1.0
To: Stan Vass <sv_forums@fmethod.com>
CC: PHP Internals <internals@lists.php.net>
References: <CAH-PCH7874id459NTuMqL6pzL=feRtaWUAiPiSqPDa73tnFy9w@mail.gmail.com> <501F46BE.4040407@sugarcrm.com> <CAFMT4NqUVF-Q_TZ_toe_7NCgYBU3J02eVWp46wf=CYRyouWdNg@mail.gmail.com> <50200FBD.2010506@sugarcrm.com> <A49B47F341F346A2922752C90973D6B5@pc>
In-Reply-To: <A49B47F341F346A2922752C90973D6B5@pc>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Error handling brainstorming
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

> Have you stopped for a moment to think this opinion through? Look at two 

Of course not. Why would I bother thinking? It is always safe to assume
nobody thinks before writing anything to the list.

> typical patterns of error handling. The examples below are generalized from 
> my file cache code. Having no cache is exceptional, because 99.999% of the 
> time I run this, there is cache, except the first time when there's not.
> 
> Tell me again how you using try..catch is very verbose and how you need to 
> supply multiple catch blocks for "every kind of exception possible"?

You are either purposefully exaggerating or not doing it right.

if(fileop1() && fileop2() && fileop3()) {
// do valid stuff
} else {
// do error stuff
}

It's not that hard.

> With exceptions:
> ----------------
> try {
>     fileop1();
>     fileop2();
>     fileop3();
>     normal_actions();
> } catch (IOException $e) {
>     exceptional_actions();
> }

Now imagine fileop1 throws some other exception - note that you have no
idea which exceptions are there and nothing guarantees you fileop1
throws only IOException, and by the proposal here, any problem in any
code whatsoever results in exception now, even if the problem was in
converting log message to utf-8 while writing some log inside some
function called by fileop2(). Now your whole app has failed, even though
you don't really care about that log message at all.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227