Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62079
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5020ABB3.7060400@sugarcrm.com>
References: <CAH-PCH7874id459NTuMqL6pzL=feRtaWUAiPiSqPDa73tnFy9w@mail.gmail.com>
	<501F46BE.4040407@sugarcrm.com>
	<CAFMT4NqUVF-Q_TZ_toe_7NCgYBU3J02eVWp46wf=CYRyouWdNg@mail.gmail.com>
	<50200FBD.2010506@sugarcrm.com>
	<CAFMT4NrYKQaARXy7b2RRGWk3qredGjPOChCGMnpEg=47iuVRmw@mail.gmail.com>
	<CAAyV7nEMsx5GbX4Rww=1JoO94AGt2J+9G629y7Wmm5G9+V8yUA@mail.gmail.com>
	<5020ABB3.7060400@sugarcrm.com>
Date: Tue, 7 Aug 2012 07:32:54 -0400
Message-ID: <CAAyV7nG6ZXhOPXK+=fSey=p6Ge_bMr0CimUz0OvSd13Nv+BaTg@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=bcaec51ba2c5f2292104c6ab5a9a
Subject: Re: [PHP-DEV] Error handling brainstorming
From: ircmaxell@gmail.com (Anthony Ferrara)

--bcaec51ba2c5f2292104c6ab5a9a
Content-Type: text/plain; charset=ISO-8859-1

Stas,

On Tue, Aug 7, 2012 at 1:46 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > circumstance. If it's not, you should be checking for existence first
> > (via file_exists() or is_readable(), etc)...
>
> This is exactly how we got into this mess with $x =
> isset($a['x'])?$a['x']:null;
> We're trying to get out of this mess and you're proposing to build
> another mess just like that.


A situation like that is not exceptional. It's null either way, therefore
no exception should be thrown. (Which is why I said earlier that I wouldn't
want most Notices to become exceptions)...


> > errors, you can't just fread the return value. You *need* to change your
> > execution flow based on that error. Therefore, it is exceptional.
>
> That's exactly what I am saying. Exceptions should not be a means of
> flow control, and that's exactly what are you doing here.


Exceptions by very definition are a means of flow control. That's their
very purpose. The difference here is that it's a means of flow control when
an error means you literally can't continue on in the current flow of
execution (such as the fopen case). To continue the current flow would
break lots of stuff, because it's expecting a resource. Therefore, the
resource not being opened is exceptional...

Anthony

--bcaec51ba2c5f2292104c6ab5a9a--