Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62056
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.211.66 cause and error)
To: Andrew Faulds <ajf@ajf.me>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, PHP Internals
 <internals@lists.php.net>
In-Reply-To: <501F0047.9080005@ajf.me>
References:
	 <CAH-PCH7QP-XxS3=+if7yoVNmCfiM4+HOhwOCDzSVJNsFEMCWRg@mail.gmail.com>
	 <1344205126.1440.1086.camel@guybrush>
	 <CAH-PCH5FmkjT+x7FpRo9C-_56reqo-m+ays3nN4b9Whpyz4AMQ@mail.gmail.com>
	 <501F0047.9080005@ajf.me>
Content-Type: text/plain; charset="UTF-8"
Date: Mon, 06 Aug 2012 01:37:57 +0200
Message-ID: <1344209877.1440.1176.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] php interactive shell without readline
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

On Mon, 2012-08-06 at 00:22 +0100, Andrew Faulds wrote:
> > to tell you the truth I'm just throwing around ideas and waiting for
> > somebody with better understanding the actual implementation to help me
> > out. ;)

I wonder which is the actual problem to solve? ;-)

Probably a better solution is to simply drop the -a mode without
readline and show a nice error message instead. Unix/Linux users should
have either libedit or readline around. For Windows this is still might
not be a complete solutions, last time I tried I failed with providing
inofficial readline builds (don't remember the problem) but maybe the
win folks can provide libedit based builds (we can't provide readline
based builds due to licensing)

> Well if linenoise() isn't that different, you could use #ifdefs to make 
> it use the correct lib at compile-time, no?

That won't solve the issue that the extension might not be there (unless
you undo the refactoring in 5.4 which means there's no way to override
using readline anymore, as mentioned in my previous mail)

johannes