Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:62002
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADNQb0WXee4cAcKGzzhXm=vP3rMJmuJntC_ZwwKE8ASgtnaxLg@mail.gmail.com>
References: <CAPwsocF=bHLo6CH4iL-7QPsYkLOyB0cA6HHjLHLVHxuQayOmxw@mail.gmail.com>
	<CADNQb0WXee4cAcKGzzhXm=vP3rMJmuJntC_ZwwKE8ASgtnaxLg@mail.gmail.com>
Date: Fri, 3 Aug 2012 12:59:37 +0100
Message-ID: <CAPwsocG0v16GJ1z7hWoOYpkew=i9+nYK+cBUzzE-+ZCPgtOXkA@mail.gmail.com>
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Why do disabled functions / classes generate a WARNING.
From: leight@gmail.com (Leigh)

> Because there isn't anything actually wrong.
>
> A fatal error is reserved for things we cannot recover from, but a
> disabled function is easily recoverable.

I don't see how it is any more recoverable than the function/class not
existing at all. How much code do you know of that checks for the
existence of every function it expects to be there, before using it?
The matter is even worse with classes, since creating a disabled class
does not return null. It returns an instantiated object with no
methods.

When an unexpected function is disabled, the engine can recover, sure.
The code, probably not. In my opinion it's better to stop the code
doing something potentially harmful than allowing it to continue with
bad data.

It seems inconsistent to me.

--

$a = new UndefinedClass; // PHP Fatal error:  Class 'UndefinedClass' not found

--

$a = new DisabledClass; // Warning
var_dump(get_class($a)); // string(13) "disabledclass"

--

$a = undefinedFunction(); // PHP Fatal error:  Call to undefined
function undefinedFunction()

--

$a = disabledFunction(); // Warning
var_dump($a); // null