Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61626
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 213.123.26.184 cause and error)
Message-ID: <500BA52C.9080201@lsces.co.uk>
Date: Sun, 22 Jul 2012 08:01:00 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120604 Firefox/13.0 SeaMonkey/2.10
MIME-Version: 1.0
To: "internals@lists.php.net >> PHP internals" <internals@lists.php.net>
References: <CADqTB_jrj__c-1d=F2zuK_Rj4J_HpXkrqPgA3J57Nxi7WBTBTg@mail.gmail.com> <CAN+gjSdiyD=BTJyoYYuwxyJLiBD-45-bzRWw9HoYRXjCOSRX3A@mail.gmail.com> <5009C8AA.10603@sugarcrm.com> <CADqTB_i8b39JXnNnv=ZUtrXBBup8f+jafhuEntgCU3CpQGSSxA@mail.gmail.com> <CAKOpQSx9GqieXx0W4vgWu_3=Am97EsHjRTi7HOcLCvERcqD4RQ@mail.gmail.com> <A78EE73B-C81A-401D-812E-ED23FE8A47C1@gmail.com> <CAN+gjScgcqo+VHFpGps75tkAyU6kX5bfwt5oq5qzMxdqZMFXVA@mail.gmail.com> <CAKOpQSxS57xMV9bzO7N_H1jQZWfUoqM_hPzbWb51yHvdxA5ZRQ@mail.gmail.com>
In-Reply-To: <CAKOpQSxS57xMV9bzO7N_H1jQZWfUoqM_hPzbWb51yHvdxA5ZRQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] common issue with version_compare()
From: lester@lsces.co.uk (Lester Caine)

Kris Craig wrote:
> *raises his hand*
>
> 1.01 and 1.0.1 are essentially the same thing.  If a versioning model
> doesn't utilize the second dot (many don't), then 1.01 would be the same as
> 1.0.1 in a project that does use it.
>
> The Gitflow model reserves that last digit for hotfixes.  However, many
> developers (including myself) drop the second dot as it's pretty much
> superfluous.  Maybe that's an American thing,  I dunno.  But having 1.1 ==
> 1.01 would cause this function to be completely and utterly *worthless *for
> many developers like myself.

Sorry Kris, but the version number system that PHP uses by definition is three 
numbers. We are currently on 5.4.x and the function is defined as
"version_compare() compares two "PHP-standardized" version number strings"
so as far as I am concerned most of this discussion has been irrelevant.

The comment posted to the page is equally in error as only one of the strings 
are in what I would call "PHP-standardized". But the main point here is that the 
function is DESIGNED to allow us to enable and disabled PHP actions based on the 
version number of PHP, so as long as the version numbers are correctly set IN 
PHP then there is nothing wrong with the function? Redefining a function to do a 
job it is not defined for is simply wrong and if you want a function that works 
for a different versioning system, then it's a new function!

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk