Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61615
Return-Path: <pierre.php@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 99619 invoked from network); 21 Jul 2012 11:13:27 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 21 Jul 2012 11:13:27 -0000
Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
X-PHP-List-Original-Sender: pierre.php@gmail.com
X-Host-Fingerprint: 209.85.160.170 mail-gh0-f170.google.com  
Received: from [209.85.160.170] ([209.85.160.170:56136] helo=mail-gh0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 53/41-27309-5DE8A005 for <internals@lists.php.net>; Sat, 21 Jul 2012 07:13:26 -0400
Received: by ghbg2 with SMTP id g2so5333103ghb.29
        for <internals@lists.php.net>; Sat, 21 Jul 2012 04:13:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=wC9MBNsZHi0Um0C8XoWd9iIxx71R7TiS/G/rVNDDkXw=;
        b=o/VZmKzsx1mGlFFyfBvJU3BlyNbsnzH7Gl+ul70FOqJHwHpjVCFOfTSWQ5Yl8aHqKZ
         Ho404b0IePN3TUfEf0q0Jxc5UNyLLeLnJ2eEksJ+u0pGPsPYTpJrSA2H1CrmurAqR4ON
         kqIEj/YZb/w82FcLaAHS9Fmy64XBMZBd/1LdHDiG6FnglScd2l/yz/lLqa/3XQGzJ1xu
         7W+LCb05Ut/Cf/IkkJBmuowcRs+6gKtYMi/Kzg1PFWXssjnDmiJ3jh3B+Md5J+XDdfop
         gZdKRiuA32KKBTDrtPMnsjaVamwC6I7EuPOoggMg9XZuc8hlkdBjMHs6cXBK1Uf6MnMO
         RiuQ==
MIME-Version: 1.0
Received: by 10.50.202.8 with SMTP id ke8mr6563902igc.6.1342869203187; Sat, 21
 Jul 2012 04:13:23 -0700 (PDT)
Received: by 10.231.137.71 with HTTP; Sat, 21 Jul 2012 04:13:23 -0700 (PDT)
In-Reply-To: <CAESVnVrFCgvXodsGL_PMz=84O4x=Zn+BuAZ9TRxVTbj-dAnWPg@mail.gmail.com>
References: <op.whnt7vdjidpuyk@damnation>
	<CAESVnVq7tCP3oCwgyq1BGz8JmoAGUY1anE_TAe2cZeErKNXCBQ@mail.gmail.com>
	<op.whpjg0eqidpuyk@damnation>
	<CAESVnVoTSP-9nXoj1LffgdhXK8L_a7aVbsgy+Z4y9ncku2EVNQ@mail.gmail.com>
	<CAF+90c_WjedgG0zZo5kGqNGUBG7YV0R6S5p-u9Z6y93oBDER2w@mail.gmail.com>
	<CAESVnVrFCgvXodsGL_PMz=84O4x=Zn+BuAZ9TRxVTbj-dAnWPg@mail.gmail.com>
Date: Sat, 21 Jul 2012 13:13:23 +0200
Message-ID: <CAEZPtU5Fy1T5j4Zau2HpANUkH0--4Db1Smy7rFO11-Qa23=EaA@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Gustavo Lopes <glopes@nebm.ist.utl.pt>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] zend_parse_parameters() improvements
From: pierre.php@gmail.com (Pierre Joye)

hi!

On Fri, Jul 20, 2012 at 12:20 AM, Sara Golemon <pollita@php.net> wrote:
> Okay, well... the main pieces of feedback I'd give on it then is to not
> change the behavior of the '!' modifier.  That's bad BC.

Fully agreed, if we can avoid the introduction of yet another set of
#ifdef, then I'm all for it.

>  Rather, introduce
> a new modifier for checking if a parameter was passed.  Secondly, make
> these two separate patches as the new modifier is a separate feature from
> the single-arg parameter parsing.

Agreed here too.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org