Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61526
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.160.170 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <CAF+90c_WjedgG0zZo5kGqNGUBG7YV0R6S5p-u9Z6y93oBDER2w@mail.gmail.com>
References: <op.whnt7vdjidpuyk@damnation>
	<CAESVnVq7tCP3oCwgyq1BGz8JmoAGUY1anE_TAe2cZeErKNXCBQ@mail.gmail.com>
	<op.whpjg0eqidpuyk@damnation>
	<CAESVnVoTSP-9nXoj1LffgdhXK8L_a7aVbsgy+Z4y9ncku2EVNQ@mail.gmail.com>
	<CAF+90c_WjedgG0zZo5kGqNGUBG7YV0R6S5p-u9Z6y93oBDER2w@mail.gmail.com>
Date: Thu, 19 Jul 2012 15:20:49 -0700
Message-ID: <CAESVnVrFCgvXodsGL_PMz=84O4x=Zn+BuAZ9TRxVTbj-dAnWPg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: Gustavo Lopes <glopes@nebm.ist.utl.pt>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8f23545314df1604c5363185
Subject: Re: [PHP-DEV] zend_parse_parameters() improvements
From: pollita@php.net (Sara Golemon)

--e89a8f23545314df1604c5363185
Content-Type: text/plain; charset=ISO-8859-1

Okay, well... the main pieces of feedback I'd give on it then is to not
change the behavior of the '!' modifier.  That's bad BC.  Rather, introduce
a new modifier for checking if a parameter was passed.  Secondly, make
these two separate patches as the new modifier is a separate feature from
the single-arg parameter parsing.

FWIW, there are a few examples of this being handled by defining the
default value of the parameter to something non-sensical (such as a length
of -1), then doing zpp with "|l!" would leave the default -1 alone when
NULL is passed, and you can treat as "not passed".  Granted this is a bit
of a hack and won't work for all situations.  Your approach is more
comprehensive, just saying that for many cases it's not strictly needed.

-Sara

On Thu, Jul 19, 2012 at 2:33 PM, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Thu, Jul 19, 2012 at 11:23 PM, Sara Golemon <pollita@php.net> wrote:
> > Then I'm not sure what problem you're trying to solve either. :/
>
> This solves two problems:
>
> a) Integer parameters cannot currently be skipped using NULL. This
> issue comes up every now and then. E.g. see
> https://github.com/php/php-src/pull/133.
>
> b) If you need more complex argument handling you currently have to
> fetch the value as z and then use some convert_to_* function. But
> those convert_to_* functions behave differently than zpp. So a
> function for parsing a single parameter is exposed too.
>
> Nikita
>

--e89a8f23545314df1604c5363185--