Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61484
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lsces.co.uk from 213.123.20.128 cause and error)
Message-ID: <500810CA.5000608@lsces.co.uk>
Date: Thu, 19 Jul 2012 14:51:06 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120604 Firefox/13.0 SeaMonkey/2.10
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
References: <5007D707.2070100@hoa-project.net> <CAOhuFvZMp4KXmkDm-uOwq6xxw5z3gfvwj1DhOjE29p+sVbKiew@mail.gmail.com> <095CAA408DA94AFB9E75C12877A9043D@charliesomerville.com> <CAOhuFvbEs5nZpYqUz7MpcjYFf+AkAb0S99CgP1pWFu-AquN07A@mail.gmail.com> <CALtuQzBb8Bhvmvc=3yR=nqaK0W2vDD4Fa-FkPUDzNObh1rvWiA@mail.gmail.com>
In-Reply-To: <CALtuQzBb8Bhvmvc=3yR=nqaK0W2vDD4Fa-FkPUDzNObh1rvWiA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Make try/catch brackets optinal
From: lester@lsces.co.uk (Lester Caine)

Sebastian Krebs wrote:
> Of course it's a matter of code style [1], but one can write the ugliest
> code with every syntax. This argument about "bug-prone" often confuses me,
> because I for myself never had such a problem. I also never knew someone,
> who had a problem with bracket-less blocks (but must say, that most write
> blocks_with_  brackets, thus they_may_  have problems). I've often just
> heard this "its bug-prone" (that sounds to me like "there are inattentive
> devs out there" to me :X) as as killer argument...

10 years in to development work on projects combining library code from many 
sources, The indenting tends to get messed up over time, and it CAN be difficult 
to spot that the brackets are missing from a block. In addition to adding them 
as I spot missing ones, the indentation will also get tidied up to make things 
readable again. The latest injection problem I had reported turned out to be in 
the smarty library. The fix involved tidying the layout just to make sure I was 
in the right place when fixing it. ( 'highlight' would quite happily pass nasty 
code! ) It's all this code, the authors of which have now retired to an easier 
live which we have to maintain going forward :(

-- 
Lester Caine - G8HFL
-----------------------------
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk
Rainbow Digital Media - http://rainbowdigitalmedia.co.uk