Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61483
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
MIME-Version: 1.0
Sender: sebastian.krebs.berlin@gmail.com
In-Reply-To: <CAOhuFvbEs5nZpYqUz7MpcjYFf+AkAb0S99CgP1pWFu-AquN07A@mail.gmail.com>
References: <5007D707.2070100@hoa-project.net>
	<CAOhuFvZMp4KXmkDm-uOwq6xxw5z3gfvwj1DhOjE29p+sVbKiew@mail.gmail.com>
	<095CAA408DA94AFB9E75C12877A9043D@charliesomerville.com>
	<CAOhuFvbEs5nZpYqUz7MpcjYFf+AkAb0S99CgP1pWFu-AquN07A@mail.gmail.com>
Date: Thu, 19 Jul 2012 15:16:01 +0200
Message-ID: <CALtuQzBb8Bhvmvc=3yR=nqaK0W2vDD4Fa-FkPUDzNObh1rvWiA@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=0016e6de03b2c0e94f04c52e9423
Subject: Re: [PHP-DEV] Make try/catch brackets optinal
From: krebs.seb@gmail.com (Sebastian Krebs)

--0016e6de03b2c0e94f04c52e9423
Content-Type: text/plain; charset=ISO-8859-1

2012/7/19 Rafael Dohms <listas@rafaeldohms.com.br>

> On Thu, Jul 19, 2012 at 12:03 PM, Charlie Somerville <
> charlie@charliesomerville.com> wrote:
>
> > This has code readability problem written all over it. When maintaining
> it
> > also has problems, like with the bracket-less if's.
> > You would need to add brackets if you add an extra line here, as well as
> > you might get unexpected behaviour of you forget to
> > add brackets in that case.
> >
> > I've often heard people make this argument, but I've never found it to be
> > a real concern in practise.
> >
> > Is this really such a common problem?
> >
>
> I have seen this problem happen, people losing time trying to figure out
> what is wrong only to find
> its a missing bracket.
> As Paul said, this is bug-prone.
>

Just curious (once more): How can anyone overlook, that the brackets are
intentionally omitted here?

if ($x) {
    // Do something
} else return null;


Of course it's a matter of code style [1], but one can write the ugliest
code with every syntax. This argument about "bug-prone" often confuses me,
because I for myself never had such a problem. I also never knew someone,
who had a problem with bracket-less blocks (but must say, that most write
blocks _with_ brackets, thus they _may_ have problems). I've often just
heard this "its bug-prone" (that sounds to me like "there are inattentive
devs out there" to me :X) as as killer argument...
At the end of the day I don't really care wether I should avoid
bracket-less blocks, or not, but ... it's this argument that annoys me :X
And I just think this just looks cute :)

try $calculator->calculateSomeVeryDifficultStuff() catch ($e) {
  // on failure
}

2cent and so on

Regards,
Sebastian


[1] I would wrap "return null;" in brackets too, if the line gets too long.

if ($x) {
    // Do something
} else {
    return someVeryLongStatement() && andSuch();
}






> --
> Rafael Dohms
> PHP Evangelist and Community Leader
> http://www.rafaeldohms.com.br
> http://www.phpsp.org.br
>

--0016e6de03b2c0e94f04c52e9423--