Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61450
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.21 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Stas Malyshev" <smalyshev@sugarcrm.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
References: <op.whnt7vdjidpuyk@damnation> <500742AA.9070307@sugarcrm.com>
Date: Thu, 19 Jul 2012 01:27:49 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.whn0snf9idpuyk@damnation>
In-Reply-To: <500742AA.9070307@sugarcrm.com>
User-Agent: Opera Mail/12.50 (Linux)
Subject: Re: [PHP-DEV] zend_parse_parameters() improvements
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

Em Thu, 19 Jul 2012 01:11:38 +0200, Stas Malyshev <smalyshev@sugarcrm.com>  
escreveu:

>> Example:
>> http://lxr.php.net/xref/PHP_TRUNK/ext/intl/timezone/timezone_methods.cpp#143
>> In this case, NULL, int and string are allowed. This would become much
>> simpler:
>>
>> if (arg == NULL || Z_TYPE_PP(arg) == IS_NULL) {
>>      se = TimeZone::createEnumeration();
>> } else {
>>      long l;
>>      char *s;
>>      int s_len;
>>      if (zend_parse_parameter(ZEND_PARSE_PARAMS_QUIET,
>>              1 TSRMLS_DC, arg, "l", &l) == SUCCESS) {
>>          TimeZone::createEnumeration((int32_t) l);
>>      } else if (zend_parse_parameter(ZEND_PARSE_PARAMS_QUIET,
>>              1 TSRMLS_DC, arg, "s", &s, &s_len) == SUCCESS) {
>>          TimeZone::createEnumeration(s);
>>      } else {
>>          //raise errror
>>      }
>
> Wait, didn't you say applying zpp to arg as l, then as s would change
> it? Or your function doesn't change it?

Yes, the zval is potentially changed in both calls (that's why the  
argument is passed with double indirection). But this is not a problem  
here (in fact, it simplifies resource management -- since the second  
zend_parse_parameter() changes the zval in the stack, the engine can  
reclaim the zval and string automatically when the function returns).

There's to argument if its processing fails. zend_parse_parameters()  
(plural) changes the arguments only until it fails. Yes, whether an  
argument is changed or not depends on its position relative to the failing  
argument.

Since zend_parse_parameter() takes only one argument this is not a problem  
-- supposedly, you call zend_parse_parameter() successfully only once. In  
any case, you can always copy the zval yourself.

> In any case, I think giving access to single-parameter parsing is a good
> idea and allows functions to implement complex cases in more consistent
> manner - right now I know there are some functions that return different
> error messages than zpp does when they parse arguments, for example -
> this can be fixes.


-- 
Gustavo Lopes