Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61440
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain nebm.ist.utl.pt from 193.136.128.22 cause and error)
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "internals@lists.php.net" <internals@lists.php.net>
Date: Wed, 18 Jul 2012 23:05:45 +0200
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Organization: =?utf-8?Q?N=C3=BAcleo_de_Eng=2E_Biom=C3=A9di?=
 =?utf-8?Q?ca_do_I=2ES=2ET=2E?=
Message-ID: <op.whnt7vdjidpuyk@damnation>
User-Agent: Opera Mail/12.50 (Linux)
Subject: zend_parse_parameters() improvements
From: glopes@nebm.ist.utl.pt ("Gustavo Lopes")

Some deficiencies in zpp have been constrai
ning the implementation of common scenarios such as 'allow integer or  
NULL'* or the more general 'allow different types for an argument'**.

So I propose the changes in this branch:

https://github.com/cataphract/php-src/compare/zpp_improv

Please see the commit messages for the rationale.

*Example:
https://github.com/php/php-src/pull/13
(again more recently on
https://github.com/php/php-src/pull/133 )
**
Example:  
http://lxr.php.net/xref/PHP_TRUNK/ext/intl/timezone/timezone_methods.cpp#143
In this case, NULL, int and string are allowed. This would become much  
simpler:

if (arg == NULL || Z_TYPE_PP(arg) == IS_NULL) {
     se = TimeZone::createEnumeration();
} else {
     long l;
     char *s;
     int s_len;
     if (zend_parse_parameter(ZEND_PARSE_PARAMS_QUIET,
             1 TSRMLS_DC, arg, "l", &l) == SUCCESS) {
         TimeZone::createEnumeration((int32_t) l);
     } else if (zend_parse_parameter(ZEND_PARSE_PARAMS_QUIET,
             1 TSRMLS_DC, arg, "s", &s, &s_len) == SUCCESS) {
         TimeZone::createEnumeration(s);
     } else {
         //raise errror
     }
}


-- 
Gustavo Lopes