Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61333
Return-Path: <adamjonr@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 87714 invoked from network); 17 Jul 2012 05:03:20 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Jul 2012 05:03:20 -0000
Authentication-Results: pb1.pair.com header.from=adamjonr@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=adamjonr@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
X-PHP-List-Original-Sender: adamjonr@gmail.com
X-Host-Fingerprint: 209.85.214.170 mail-ob0-f170.google.com  
Received: from [209.85.214.170] ([209.85.214.170:34129] helo=mail-ob0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id CD/51-12983-712F4005 for <internals@lists.php.net>; Tue, 17 Jul 2012 01:03:19 -0400
Received: by obfk16 with SMTP id k16so16635obf.29
        for <internals@lists.php.net>; Mon, 16 Jul 2012 22:03:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=0UP1ck4G1D8FZMlfSzsDbedVmgV4p0bK3H/r+3tdq7Q=;
        b=oOd5TRnhzx7yAkSgoxU6YfcLedg1aqQ5SIUTq2XTrgMptsxeVeR4K7i0LyvW03fO3O
         lHEouY/dlaRJfyuba62ZFjIZvZeTSadMH5zYqMK8F4ZIotAZuNiToNJVmeNsL40rmssX
         BZ/plWSVpxeumNubMG4EUsTn9HGNwUztC61vp3UDvI38IFSenvdaGEqohnzRoKSco0cD
         khRE7pdcrYUfSPBlSmsph/Hj7w/FThl6/OyD54M5pX/ATFVduaK8HD4QEVkORodWxWOY
         pYi9NHgbRtiXe9ZEfTDiWkerPh3MrpHxfUF9t7o7d9PkPcX0y4BenZcyHAilBtACI+qI
         P1Pg==
MIME-Version: 1.0
Received: by 10.60.31.237 with SMTP id d13mr1353212oei.27.1342501396436; Mon,
 16 Jul 2012 22:03:16 -0700 (PDT)
Received: by 10.76.116.168 with HTTP; Mon, 16 Jul 2012 22:03:16 -0700 (PDT)
In-Reply-To: <CAAyV7nGkydKMFE3N4XzUr14cj1Qdi2KTWWdUNoBktUQOhJVd8A@mail.gmail.com>
References: <CAJRMtAHphgKXkBcD0YW24HUob+a27=xKo6V2qi4WMzYG+Vw=+w@mail.gmail.com>
	<CAAyV7nEOVMRKmFvcxdnjb9YW5HZSt3JnbpkPG+vOHoxLz-qPFw@mail.gmail.com>
	<CAJRMtAH6ed8A2BqF2YBQoaqkm+wWxoGo4aWjcCr+Qj=wktXv8A@mail.gmail.com>
	<CAAyV7nGkydKMFE3N4XzUr14cj1Qdi2KTWWdUNoBktUQOhJVd8A@mail.gmail.com>
Date: Tue, 17 Jul 2012 01:03:16 -0400
Message-ID: <CAJzDObdpY-Qw5K_u7T5G8iYgTJe4T_G4CfnbbC8CznFD-=SGvw@mail.gmail.com>
To: internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] DOMDocument and <script> tag - XSS test
From: adamjonr@gmail.com (Adam Jon Richardson)

On Mon, Jul 16, 2012 at 10:25 PM, Anthony Ferrara <ircmaxell@gmail.com> wrote:
> This is standard and expected behavior. Since " has no special meaning
> within a document (outside of an attribute declaration), there is no
> requirement to escape it. And the standard practice when parsing XML/HTML
> using a dom based parser is to decode the values. So the "&quot; gets
> turned into "". The short answer, is you're doing it wrong, so there's
> nothing that *can* be done to prevent the behavior. It's the standard
> behavior defined in the standards definitions relating to how to parse HTML
> and XML.

Well, speaking specifically to the standard practices of dom-based
parsers and avoiding the potential security issues, I think most of
what you said is correct UNLESS entities are within CDATA, script, or
style nodes, in which case the entity should remain in an HTML-aware
parser:
http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/introduction.html#ID-E7C30824

That said, please correct me if I'm wrong this (as my wife would tell
you, I'm wrong all the time :)

Adam