Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61330
Return-Path: <xwisdom@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 73546 invoked from network); 17 Jul 2012 01:30:15 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Jul 2012 01:30:15 -0000
Authentication-Results: pb1.pair.com header.from=xwisdom@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=xwisdom@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
X-PHP-List-Original-Sender: xwisdom@gmail.com
X-Host-Fingerprint: 209.85.217.170 mail-lb0-f170.google.com  
Received: from [209.85.217.170] ([209.85.217.170:53602] helo=mail-lb0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id A6/D1-62735-520C4005 for <internals@lists.php.net>; Mon, 16 Jul 2012 21:30:14 -0400
Received: by lbgc1 with SMTP id c1so9339376lbg.29
        for <internals@lists.php.net>; Mon, 16 Jul 2012 18:30:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=UOr4Y2K4gU0AQrPHy2AzqGNt9OzIQCufXWwktY8YAAU=;
        b=EVtZy+/0vBs3eCtH7NrtMzm56l4tQbIZQlN0+xZP7e+jhTECONACoAhW2ise6FWcf2
         NWOEhlDFx4/9dfwt6wEyO/PKlV+8yjS6RBEgZ8LevjBFZ5VDoVdInh3Lmgi0vy9eEmW7
         URDammjVBp3pe97lugFuq1PTMlm61YTBMhuzhfuwpDCquMr7BIbfdmOLkcjJsVaRSags
         kNZvq0/faHhDeZbIzLG9bx/s5Ls6WUy45FbWdL/relYMKNkSZ0mUhwlmyPSa78uD8DcT
         FApWntuFhV2r9nrG7njk2kKUDkBHBvBXHDrG8ow7bv3gOVzualfRfdN7DQ8mmA5TjMSo
         Nfwg==
MIME-Version: 1.0
Received: by 10.112.84.168 with SMTP id a8mr284530lbz.92.1342488610647; Mon,
 16 Jul 2012 18:30:10 -0700 (PDT)
Received: by 10.112.85.201 with HTTP; Mon, 16 Jul 2012 18:30:10 -0700 (PDT)
In-Reply-To: <CAAyV7nEOVMRKmFvcxdnjb9YW5HZSt3JnbpkPG+vOHoxLz-qPFw@mail.gmail.com>
References: <CAJRMtAHphgKXkBcD0YW24HUob+a27=xKo6V2qi4WMzYG+Vw=+w@mail.gmail.com>
	<CAAyV7nEOVMRKmFvcxdnjb9YW5HZSt3JnbpkPG+vOHoxLz-qPFw@mail.gmail.com>
Date: Mon, 16 Jul 2012 20:30:10 -0500
Message-ID: <CAJRMtAH6ed8A2BqF2YBQoaqkm+wWxoGo4aWjcCr+Qj=wktXv8A@mail.gmail.com>
To: Anthony Ferrara <ircmaxell@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f46d04016cadc0adf504c4fc7c5b
Subject: Re: [PHP-DEV] DOMDocument and <script> tag - XSS test
From: xwisdom@gmail.com (Raymond Irving)

--f46d04016cadc0adf504c4fc7c5b
Content-Type: text/plain; charset=ISO-8859-1

Hi Anthony,

Thanks for the feedback. I do get your point about escaping for JavaScript
but the example shown was just to highlight the entity substitution issue
which could lead to unexpected results. In this case a developer might want
to use jQuery to append some html escaped values to an element which would
result in an error of a possible XSS attack.

IMO there should be a feature to control or prevent this behavior.

__
Raymond

On Mon, Jul 16, 2012 at 6:31 AM, Anthony Ferrara <ircmaxell@gmail.com>wrote:

> The problem is that you're escaping incorrectly for the context. It takes
> more than just htmlspecialchars to escape for a javascript data context.
>
> Check this out:
>
>
> https://www.owasp.org/index.php/XSS_(Cross_Site_Scripting)_Prevention_Cheat_Sheet#RULE_.233_-_JavaScript_Escape_Before_Inserting_Untrusted_Data_into_JavaScript_Data_Values
>
>
> Anthony
>
>
> On Mon, Jul 16, 2012 at 12:54 AM, Raymond Irving <xwisdom@gmail.com>wrote:
>
>> Hello,
>>
>> I'm having a problem with the DOM parser:
>>
>> If I load the following using DOMDocument->loadHTML():
>>
>> <script type="text/javascript"><!--
>>    var d="&quot;;alert('This is an XSS test'); //";
>> </script>
>>
>> it will be converted to:
>>
>> <script type="text/javascript"><!--
>>    var d="";alert('This is an XSS test'); //";
>> </script>
>>
>> This is because parser is substituting '&quot;' for  '"'.
>>
>> Is there a way to prevent this from happening?
>>
>> __
>> Raymond
>>
>
>

--f46d04016cadc0adf504c4fc7c5b--