Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61287
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <5003F9BF.4010209@anderiasch.de>
References: <CAKxcST81XuT7XF4PJQ_++7+jkrZT8MRcQMFhbjGbw32rJmiwJg@mail.gmail.com>
	<CA+5g0SLBGX7sxB6dmSewNFcfbe+NfPn6iKKeqGV+bpgn7EwkGg@mail.gmail.com>
	<CAKxcST9UYx4XdS9XKtj+s021iWXCtDNHxbcouF-xoWdEkT+CVg@mail.gmail.com>
	<4672bc1ca5a1ad95956b60ea654f7b24@nebm.ist.utl.pt>
	<5003CC02.6070709@kingsquare.nl>
	<CAKxcST99sS40nJGnCv5ePn0r7RAs5+KNpmvf6K=qGP0bzVe8GQ@mail.gmail.com>
	<5003F9BF.4010209@anderiasch.de>
Date: Mon, 16 Jul 2012 12:30:39 +0100
Message-ID: <CAKxcST-SDpmBtSaRW3Gqk-k6q33k+3XKDhDSEco35qa9UR_ryQ@mail.gmail.com>
To: Florian Anderiasch <florian@anderiasch.de>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] New String Function: str_replace_limit
From: dragoonis@gmail.com (Paul Dragoonis)

On Mon, Jul 16, 2012 at 12:23 PM, Florian Anderiasch
<florian@anderiasch.de> wrote:
> On 07/16/2012 10:29 AM, Paul Dragoonis wrote:
>> Thanks for the comments guys, I like your idea about skipping the
>> by-ref count parameter.
>>
>> If the 'default' keyword were to be added in, then you could skip the
>> 4th parameter and add your 5th 'limit' option.
>>
>> $str = str_replace($search, $replace, $subject, default, 5);
>>
>> Does anyone have any objections on this implementation approach?
>> (obviously we'd have to wait for the default param skipping to be
>> implemented, I'm not sure on the implementation status of that
>> feature)
>
> I'm not seeing what's the problem with it being a by-ref variable, as
> you've mentioned it twice now. Are you bothered by an additional
> variable being set in memory when skipping (i.e. not using it)? Or am I
> reading more into it than you tried to say? :)

I believe you were reading more into it.

I mention by-ref so it's easy to know if i'm talking about the
existing or new proposed param.

I'm not bothered by the by-ref param being skipped over to get to the
5th one, it's a hit I'm willing to take to achieve necessary
functionality on str_replace().

If nobody has any further concerns I'll go ahead and create this new
parameter and provide a PR on github accordingly.

Paul Dragoonis.

>
> Greetings,
> Florian