Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61252
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <50025BCE.1090409@sugarcrm.com>
References: <50025BCE.1090409@sugarcrm.com>
Date: Sun, 15 Jul 2012 21:27:54 +0200
Message-ID: <CAEZPtU463wvJ=qxT7tFXCCtbnqtB6Z-1_1th8ohZ8eEpq6Pghw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] bug #49510
From: pierre.php@gmail.com (Pierre Joye)

hi!

On Sun, Jul 15, 2012 at 7:57 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
> We've got a bit of a discussion on bug #49510 in the comments. The
> problem is this: filter_var('', FILTER_VALIDATE_BOOLEAN, array("flags"
> => FILTER_NULL_ON_FAILURE)) returns "null" (i.e. failure) while docs say
> boolean filter will return false on ''. I think we need to sync with the
> docs.
> The question is - should we apply it to 5.3/5.4? It is a behavior
> change, even though current code behavior does not match documented
> behavior.

The question is more about the correctness of the doc, and to what I
remember (I implemented that NULL on failure thing), the doc is wrong.
And the null on failure was mainly implemented for this exact case
(boolean validation).

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org