Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:61188 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42372 invoked from network); 12 Jul 2012 18:34:48 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Jul 2012 18:34:48 -0000 Authentication-Results: pb1.pair.com smtp.mail=ircmaxell@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ircmaxell@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.42 as permitted sender) X-PHP-List-Original-Sender: ircmaxell@gmail.com X-Host-Fingerprint: 209.85.216.42 mail-qa0-f42.google.com Received: from [209.85.216.42] ([209.85.216.42:61552] helo=mail-qa0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 59/76-11045-8C81FFF4 for ; Thu, 12 Jul 2012 14:34:48 -0400 Received: by qafi31 with SMTP id i31so4493430qaf.8 for ; Thu, 12 Jul 2012 11:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4jAubcyRWFCVdEiczj3kENs0/5B3CFm5gb7vTq+2A68=; b=RUbuRVutAg7DtlCXLWxpizSi6abzvqYkedF+GvvnFunTHXGBM7pm5Q9eoI+Ze5+Lth wh4ktHG3gPoTsAyUS2AQStmByl8i6zgQDckaresCe7hNnmXqE9KZS4CvyGAxkpJc6VHd Q8vz9PT4PUy01l8aL2aeUPuPgEXDHzmk5W2NJ36v+URvVU3FI2c0go+x1GRBYQkQtx6h wwRqJs+7KU2FP80zXv0l3D1iEXP8d4moO4/Fxrs3AHIDHoX3k8CxJQKCow1RqVcNaF3p Aj4PN95BH2GL/9RIFnPDDxvNGY9pHf0d0GffzNvTw+y6lJIdko4qL+VURsaT6FbSTiuQ Jrqg== MIME-Version: 1.0 Received: by 10.224.59.212 with SMTP id m20mr6254975qah.35.1342118085394; Thu, 12 Jul 2012 11:34:45 -0700 (PDT) Received: by 10.229.232.11 with HTTP; Thu, 12 Jul 2012 11:34:45 -0700 (PDT) In-Reply-To: <4FFF1831.8070902@sugarcrm.com> References: <4FFF1831.8070902@sugarcrm.com> Date: Thu, 12 Jul 2012 14:34:45 -0400 Message-ID: To: Stas Malyshev Cc: "internals@lists.php.net" Content-Type: multipart/alternative; boundary=20cf3074d5b8ba019204c4a63756 Subject: Re: [PHP-DEV] [PROPOSED] password_hash RFC - Implementing simplified password hashing functions From: ircmaxell@gmail.com (Anthony Ferrara) --20cf3074d5b8ba019204c4a63756 Content-Type: text/plain; charset=ISO-8859-1 Stas, > https://wiki.php.net/rfc/password_hash > > Looks good. The only question I have is for password_make_salt() - do we > need the user to specify length? I think length is defined by the > algorithm in the most cases. Maybe convert it to password_make_salt(int > $salt_type = PASSWORD_SALT_BCRYPT, int $length) > with both arguments optional and one of salt types being > PASSWORD_SALT_OTHER which just generates given length? My only heistation there is that SALT_* specifies the format. So all of the crypt() hashes would use that format (a-zA-Z0-9./). Perhaps the name is bad, and it should be SALT_CRYPT instead (but this has the assumption that salt formats will never change for crypt())... --20cf3074d5b8ba019204c4a63756--