Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:61186 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 39806 invoked from network); 12 Jul 2012 18:32:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Jul 2012 18:32:24 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.203 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.203 smtp203.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.203] ([67.192.241.203:54012] helo=smtp203.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 6F/D5-11045-5381FFF4 for ; Thu, 12 Jul 2012 14:32:22 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp10.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 379DC1B83D6; Thu, 12 Jul 2012 14:32:18 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp10.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id EE0B81B8292; Thu, 12 Jul 2012 14:32:17 -0400 (EDT) Message-ID: <4FFF1831.8070902@sugarcrm.com> Date: Thu, 12 Jul 2012 11:32:17 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Anthony Ferrara CC: "internals@lists.php.net" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PROPOSED] password_hash RFC - Implementing simplified password hashing functions From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > https://wiki.php.net/rfc/password_hash Looks good. The only question I have is for password_make_salt() - do we need the user to specify length? I think length is defined by the algorithm in the most cases. Maybe convert it to password_make_salt(int $salt_type = PASSWORD_SALT_BCRYPT, int $length) with both arguments optional and one of salt types being PASSWORD_SALT_OTHER which just generates given length? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227