Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:61155 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17496 invoked from network); 12 Jul 2012 05:59:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Jul 2012 05:59:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.133 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.133 smtp133.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.133] ([67.192.241.133:52313] helo=smtp133.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DD/A2-32936-6D76EFF4 for ; Thu, 12 Jul 2012 01:59:50 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp23.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id BA22C2F8251; Thu, 12 Jul 2012 01:59:47 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp23.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 71E3A2F81B0; Thu, 12 Jul 2012 01:59:47 -0400 (EDT) Message-ID: <4FFE67D2.9020302@sugarcrm.com> Date: Wed, 11 Jul 2012 22:59:46 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tomas Kuliavas CC: "internals@lists.php.net" References: <4FFD11C1.3090007@sugarcrm.com> <1342029955.13569.17.camel@guybrush> <4FFDC10F.6050106@sugarcrm.com> <4FFDDBAD.7070100@sugarcrm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: bug 18556 - tolower & locales From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! > You had less complex patch posted on #35050 bug report for the last four > years. That patch, unfortunately, is not correct since it assumes every function using tolower wants ASCII tolower. This makes, for example, substr_compare() ignore locale, and probably a bunch of other functions. Which is probably not a desired effect. > Code already uses (or used when I was looking at that code) locale > insensitive tolower version on Windows. Why you insist on using locale > sensitive function on other platforms. I don't know when you looked at the code, but right now for windows the following is used: #define zend_tolower(c) _tolower_l(c, current_locale) As specified in http://msdn.microsoft.com/en-us/library/8h19t214.aspx, this is definitely locale sensitive function. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227