Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:61120 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96152 invoked from network); 11 Jul 2012 05:40:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Jul 2012 05:40:22 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.183 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.183 smtp183.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.183] ([67.192.241.183:48607] helo=smtp183.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8F/92-01957-4C11DFF4 for ; Wed, 11 Jul 2012 01:40:21 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp8.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id 770BD8361; Wed, 11 Jul 2012 01:40:18 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp8.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 28ED5835B; Wed, 11 Jul 2012 01:40:18 -0400 (EDT) Message-ID: <4FFD11C1.3090007@sugarcrm.com> Date: Tue, 10 Jul 2012 22:40:17 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: PHP Internals , =?ISO-8859-1?Q?Johannes_Sc?= =?ISO-8859-1?Q?hl=FCter?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: bug 18556 - tolower & locales From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! I've prepared a fix for bug #18556 - see https://github.com/php/php-src/pull/126 A slight complication there is that for internal operations we probably want locale-independent lowercasing, while for regular string operations we probably want to stay with locale-depenedent one. That's how I implemented it, even though it adds a bit of complexity, but I think it's the best way to solve it. Any comments/objections/improvements? Johannes, is it ok to put this fix into 5.3 too? -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227