Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61111
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4FF77065.101@sugarcrm.com>
References: <CACpmCxLLkJQRHEXWS2Q=mJVzTNRdXcwR4RtMqL-GYTOOmAEhjg@mail.gmail.com>
	<CACpmCxJSD2oCyKZE-eBbZXhuCC1R6Gu9igdUFUw8g1XvR4vSOg@mail.gmail.com>
	<4FF77065.101@sugarcrm.com>
Date: Sat, 7 Jul 2012 09:23:52 -0400
Message-ID: <CACpmCxJXCxfNnPD4QiJJ1ZPJLij4FARU_ULo9rxcEZ58V7qPOA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=e89a8fb1ed4ab35bb804c43d4a3e
Subject: Re: [PHP-DEV] Re: [PATCH] Feature 55218 - SimpleXML namespaces
From: lonnyk@gmail.com (Lonny Kapelushnik)

--e89a8fb1ed4ab35bb804c43d4a3e
Content-Type: text/plain; charset=ISO-8859-1

Hi Stas,

Thanks for the response!

Usually it helps to talk to extension maintainer (list of them in in
> EXTENSIONS file).
>
In the original message of this thread I CCed the extension maintainer
listed in EXTENSIONS (per the instructions in the README.SUBMITTING_PATCH)
and I did not hear anything back. Previously, when I originally wrote this
feature, I sent a private e-mail to the 3 maintainers listed on top of the
simplexml.c file and did not hear anything back either (this was on
2011-08-31).


> Speaking of the patch, could you explain what is it returning when
> recursive is set but from_root is false?
>
It will only return the namespaces below and including the node you call it
on.

Say you have an XML doc like https://gist.github.com/3066372

Currently, if you call $x->getDocNamespaces(true) and
$x->person[0]->getDocNamespaces(true) you get the same results. This is
because the recursive call *always* starts from the root of the document.

With the patch, when from_root is false the recursion will start from the
node you call getDocNamespaces on. So when
calling $x->getDocNamespaces(true, false) and
$x->person[0]->getDocNamespaces(true, false) they return results based on
the node they were called on.


> Besides that, it looks OK but also needs NEWS and UPGRADING
> descriptions. Please add those and I think it can be merged.

These are now added.

Thank you for your help! Please let me know if anything else needs to be
changed.

Have a great day!

-- 
Lonny Kapelushnik
http://lonnylot.com
(732) 807-5509

--e89a8fb1ed4ab35bb804c43d4a3e--