Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61063
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4FEF90F5.4090502@sugarcrm.com>
References: <4FEF84D8.20107@sugarcrm.com>
	<CAF+90c-dbNetJJ4BiNjKrqfNWZecNj_dR1z4bAmddB6bxhUXdQ@mail.gmail.com>
	<4FEF90F5.4090502@sugarcrm.com>
Date: Sun, 1 Jul 2012 23:06:36 +0200
Message-ID: <CAF+90c_vnX2Q+yP=C5Fm5ciSkK-my=XDRyisy_wN=WazRORzJw@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: Nikita Popov <nikita.ppv@googlemail.com>, 
	=?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>, 
	Pierre Joye <pierre.php@gmail.com>, David Soria Parra <dsp@php.net>, 
	PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: JSON changes in 5.3/5.4
From: nikita.ppv@gmail.com (Nikita Popov)

On Sun, Jul 1, 2012 at 1:51 AM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
>> If you are okay with the changes in principle, I will fix the
>> remaining issues asap. If you think that the changes are too intrusive
>> for release branches, I'll gladly revert them for 5.3/5.4. I didn't
>> quite expect that there will be so many changes.
>
> I think changes with adding new functions, etc. are too intrusive for
> 5.3/5.4. If you have any fixes that can be done without it, please
> describe them and let's see if they fit stable versions. Otherwise,
> let's go back to stable. In any case, the tests should be fixed too.

I don't think one can do anything on 5.3/5.4 without altering the
behavior too drastically. I reverted all changes I did there:

https://github.com/php/php-src/commit/250393f92523fffe643df06a1de2101fd50a327e
(5.3)
https://github.com/php/php-src/commit/b7903f9778a57fda71867f9661505f635d602067
(5.4)

I did not revert
http://git.php.net/?p=php-src.git;a=commit;h=3f3ad30c50c32327e723046bcc6649d05dd9236a
though. Leaving the decision on that one to Johannes :)

Nikita