Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61037
Return-Path: <nikita.ppv@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 62013 invoked from network); 29 Jun 2012 12:43:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 29 Jun 2012 12:43:14 -0000
Authentication-Results: pb1.pair.com header.from=nikita.ppv@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
X-PHP-List-Original-Sender: nikita.ppv@gmail.com
X-Host-Fingerprint: 209.85.217.170 mail-lb0-f170.google.com  
Received: from [209.85.217.170] ([209.85.217.170:43018] helo=mail-lb0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id BF/E0-62543-0E2ADEF4 for <internals@lists.php.net>; Fri, 29 Jun 2012 08:43:13 -0400
Received: by lbgc1 with SMTP id c1so5186654lbg.29
        for <internals@lists.php.net>; Fri, 29 Jun 2012 05:43:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:date:message-id:subject:from:to:content-type;
        bh=G1pxBJRMPMD3kgIzNpQPt9F/mVfArIKjPRNj0DCBQ5A=;
        b=D8Gxv3gXegg8eKB39ZP58qlf5nP+jAygx80sQvcPtIgu7q76m0lkoc+P3/6FkQxvUs
         wgDJcQUUOPhDm4NSwnB6UIAxv6wb4zbObo2b6nv9h/7QhdLM6lW3ELmiphvzxqdRj0N7
         vaFVPwvqkvKHXeOMAYk7xV2Oj+jLK/zVjbncgTQT9YWUNvLG7E1nc8jnxzI7uVpM88vA
         b/8WcbzNbzahnqVxDVpMAcfuWgZQuZ4bkVOhiHV0tDd7I4CvbqA4n6qBP/AEFl24eybY
         hk7QQkNwYT9HyYvhYkvmlbyb2wHFVH2BHW5i68IW73qXvIbxECNZ3WmIGwHfmaRwWbZO
         k/5Q==
MIME-Version: 1.0
Received: by 10.152.144.168 with SMTP id sn8mr1860723lab.1.1340973790118; Fri,
 29 Jun 2012 05:43:10 -0700 (PDT)
Received: by 10.152.114.70 with HTTP; Fri, 29 Jun 2012 05:43:10 -0700 (PDT)
Date: Fri, 29 Jun 2012 14:43:10 +0200
Message-ID: <CAF+90c_e6Lzd_TZXW-2J_fJjNH=3Up9W744=KH5nbwTE_eUDzw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Asking for a review of crypt() allocation changes
From: nikita.ppv@gmail.com (Nikita Popov)

Hi internals!

Anthony and me have been looking a lot at the crypt() code recently
and noticed that there are some strange things going on in the buffer
allocations for the sha algorithms.

We did two commits to fix them up a bit:

http://git.php.net/?p=php-src.git;a=commitdiff;h=7e8276ca68fc622124d51d18e4f7b5cde3536de4
http://git.php.net/?p=php-src.git;a=commitdiff;h=e6cf7d774519300c08399cae5bfba90e33749727

The complete code is here:
http://lxr.php.net/xref/PHP_TRUNK/ext/standard/crypt.c#150

To prevent another crypt() mess, I'd really appreciate if some people
familiar with the code could look over it.

Nikita