Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:61031
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAF+90c-K7L=-YDS2n=ged1LAOHq5EQiexa9Yn6p7ywy9oq1-pw@mail.gmail.com>
References: <CAF+90c-T9hPbuS3bUxnHw-+B+Y2VLu55wQJ8UrtzrcC7TiKyVw@mail.gmail.com>
	<20120621141241.GA25789@analysisandsolutions.com>
	<CAF+90c8=5C_C9wa0q-Tf0OB2vKBow2PH8Nqu5n2SUm=xU1gKgQ@mail.gmail.com>
	<4FE33EDF.2000409@lerdorf.com>
	<CAL+t6cGZX5Db7L+0FAc7aCRXueE2O7A-_=NrmoTCteEWWkv-2w@mail.gmail.com>
	<CAF+90c-NLQhGJ+H1POirt8pcxLeGBvQ5AYiBzj7Z1UOSu+YPZw@mail.gmail.com>
	<4FE61E9D.5050908@sugarcrm.com>
	<op.wgdodznfidpuyk@damnation.nl.lo.geleia.net>
	<CAF+90c_JW-B7N64fXS1HwZxiCZqcjQo80VFzy7MxQuXJh2cUew@mail.gmail.com>
	<4FE734C4.2010706@lerdorf.com>
	<CAF+90c-RoCwANfjiyM6rp=_1h1N=FiTHdKso-sN4YLHSMu3zbg@mail.gmail.com>
	<4FEA489D.1010601@sugarcrm.com>
	<CAEPJdukOO32yM0GRp5G2nirpNS=0W2=3QKCQ_7yHpKoNHUm5Kg@mail.gmail.com>
	<CAF+90c_8JbJK1nNezOxuo+oX_iDuTP6nQ29B_=hLOOv++2_3MQ@mail.gmail.com>
	<CAEZPtU5y2WpphwjWq=6DUfVUUYhWuuuef81FRPDMyVjs125Csg@mail.gmail.com>
	<CAF+90c-K7L=-YDS2n=ged1LAOHq5EQiexa9Yn6p7ywy9oq1-pw@mail.gmail.com>
Date: Thu, 28 Jun 2012 20:36:40 +0200
Message-ID: <CAF+90c9PDPkSCB1JL-q42+KN-Cx7vp60d6GKZrPcSjK5FLbUKQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@googlemail.com>
Cc: Pierre Joye <pierre.php@gmail.com>, Benjamin Eberlei <kontakt@beberlei.de>, 
	Stas Malyshev <smalyshev@sugarcrm.com>, Rasmus Lerdorf <rasmus@lerdorf.com>, 
	Gustavo Lopes <glopes@nebm.ist.utl.pt>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] json_encode() behavior for incorrectly encoded strings
From: nikita.ppv@gmail.com (Nikita Popov)

On Wed, Jun 27, 2012 at 2:19 PM, Nikita Popov <nikita.ppv@googlemail.com> wrote:
> I looked at a few other error functions (of which we by the way we
> have *loads*, which is a bad sign) and indeed it seems that they all
> use a separate function to get the error message. Most use a
> xyz_errno() + xyz_error() pair.
>
> So it seems reasonable to instead provide the functionality via
> json_last_error_msg().

I replaced json_last_error(true) with json_last_error_msg() now (in
https://github.com/php/php-src/commit/974324676b2436f159f42d9241c569f813471684).

I kind of get the feeling that the changes turned out much more
intrusive than originally thought. Maybe the best thing to do would be
to revert all changes on 5.3/5.4 (including the very original one that
landed only on 5.3) and only introduce the new behavior on master. Or
do you think that the changes are okay for the release branches?

Nikita